Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude demo image from extension package #711

Merged
merged 1 commit into from
Sep 20, 2022
Merged

Conversation

kidonng
Copy link
Contributor

@kidonng kidonng commented Aug 21, 2022

I noticed a demo image isn't excluded from the extension package, hence this pull request. With this change, package size is down from 1.59MB to 390.76KB.

It does not break the links as VSCode rewrites assets in README to use GitHub links.

@CLAassistant
Copy link

CLAassistant commented Aug 21, 2022

CLA assistant check
All committers have signed the CLA.

@kidonng kidonng changed the title Add usage demo to .vscodeignore Add demo image to .vscodeignore Aug 21, 2022
@kidonng kidonng changed the title Add demo image to .vscodeignore Exclude demo image from extension package Aug 21, 2022
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ry ry merged commit 4bbba7c into denoland:main Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants