feat: register notebook cells with the language client #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
approved these changes
Sep 28, 2023
client/src/extension.ts
Outdated
| code2Protocol: (uri) => { | ||
| if (uri.scheme == "vscode-notebook-cell") { | ||
| const string = uri.with({ | ||
| scheme: "deno-file-fragment", |
No they're stored as unrelated documents in my current mvp. (But now that I think about it, if we support that I don't think a generic The fragment of the URI seems to contain an index to the cell. Other than that I'm not sure how to decode it properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start sending notebook cells to the LSP.
VSCode stores these cells as documents with URLs like:
When sending them to the LSP, I've mapped them to:
because it's neutral to other editors.