Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property 'consoleSize' does not exist on type 'typeof Deno' #8

Closed
tscpp opened this issue Jul 28, 2021 · 2 comments · Fixed by #9
Closed

Property 'consoleSize' does not exist on type 'typeof Deno' #8

tscpp opened this issue Jul 28, 2021 · 2 comments · Fixed by #9

Comments

@tscpp
Copy link
Contributor

tscpp commented Jul 28, 2021

The package depends on that the '--unstable' flag is enabled. I do not want to enable unstable APIs and until 'Deno.consoleSize' is a stable API the consoleSize should be optional. I think a "try-catch" statement is enough for supporting stable versions.

error: TS2339 [ERROR]: Property 'consoleSize' does not exist on type 'typeof Deno'. 'Deno.consoleSize' is an unstable API. Did you forget to run with the '--unstable' flag?
    const columns = Deno.consoleSize(this.#stream.rid)?.columns || 80;

    at https://deno.land/x/wait@0.1.11/mod.ts:208:26
@eliassjogreen
Copy link
Member

I will get to it once i get home from vacation.

@eliassjogreen
Copy link
Member

Unless you would like to create a pull request implementing such a feature which would be much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants