feat(logging.ts, mod.ts): add console interception to stop spinner while logging and resume after logging is done #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ile logging and resume after logging is done This change adds a new feature to the spinner module that allows it to intercept console methods and stop the spinner while logging is being done. This is useful to avoid the spinner animation interfering with the logs. After the logging is done, the spinner resumes its animation. The feature is enabled by default but can be disabled by setting the `interceptConsole` option to `false`. The `logging.ts` file is an example of how to use this feature.
feat(Spinner): add support for intercepting console methods to allow for logging during spinner execution
…d improve type safety in Spinner class by using Console interface instead of any for console object methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a new feature to the spinner module that allows it to intercept console methods and stop the spinner while logging is being done. This is useful to avoid the spinner animation interfering with the logs. After the logging is done, the spinner resumes its animation. The feature is enabled by default but can be disabled by setting the
interceptConsoleoption tofalse. Thelogging.tsfile is an example of how to use this feature.