support tests/ with elm 0.19.0

[altaurog]

With earlier elm versions, a separate package file is maintained for tests, which when properly configured enabled the compiler to find what it needed to compile the tests. Under elm 0.19, test dependencies are managed in the top-level package file, so elm make will fail on the tests. elm-test make is required in this case.

See elm-explorations/test#64

I am unable to test on windows currently, but it works for me in the wild, and I have added tests for the new behavior.

Also I updated the tests to test behavior when elm package file is present (which is pretty much always).

[altaurog]

Okay, I see that the CI tests do run on windows, and will have a look at fixing them.
The travis CI build failure is harder to understand. I ran all the docker tests with run-test and they passed. Any suggestions on how to debug that?

[RyanSquared]

Easiest way is ctrl-f and look for (X):

  Starting Vader: /testplugin/test/command_callback/test_elm_make_command_callback.vader
    (1/5) [EXECUTE] should get valid executable with default params
    (2/5) [EXECUTE] should get elm-test executable for test code with elm >= 0.19
    (2/5) [EXECUTE] (X) ['elm', 'cd ''/testplugin/test/elm-test-files/newapp'' && ''elm'' make --report=json --output=/dev/null %t'] should be equal to ['/testplugin/test/elm-test-files/newapp/node_modules/.bin/elm-test', 'cd ''/testplugin/test/elm-test-files/newapp'' && ''/testplugin/test/elm-test-files/newapp/node_modules/.bin/elm-test'' make --report=json --output=/dev/null %t']
    (3/5) [EXECUTE] should get plain elm executable for test code with elm < 0.19
    (3/5) [EXECUTE] (X) ['elm', 'cd ''/testplugin/test/elm-test-files/oldapp'' && ''elm'' make --report=json --output=/dev/null %t'] should be equal to ['/testplugin/test/elm-test-files/oldapp/node_modules/.bin/elm', 'cd ''/testplugin/test/elm-test-files/oldapp'' && ''/testplugin/test/elm-test-files/oldapp/node_modules/.bin/elm'' make --report=json --output=/dev/null %t']
    (4/5) [EXECUTE] should get valid executable with 'use_global' params
    (5/5) [EXECUTE] should get valid executable with 'use_global' and 'executable' params
  Success/Total: 3/5

[altaurog]

@RyanSquared thanks. Finding the failed test (mine) wasn’t a problem. What I don’t understand is why the results of the CI would differ from the results I get when I run the docker container locally, since on the face of it, the environments should be the same. If I find more time for this, I will dig deeper. In the meantime, it works for me, at least.

[altaurog]

ah. I see.

[altaurog]

Well, this PR is ready to go. It seems that the test failures are coming from master.

[w0rp]

Yeah, I'll fix those. I'm not surprised if Windows tests can fail.

[w0rp]

Cheers! 🍻

[altaurog]

thanks!