Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linter for powershell syntax errors #2413

Merged
merged 6 commits into from
Apr 13, 2019
Merged

Linter for powershell syntax errors #2413

merged 6 commits into from
Apr 13, 2019

Conversation

zigford
Copy link
Contributor

@zigford zigford commented Apr 4, 2019

  • Moved the RunPowershell function out of the psscriptanalyzer into autoload/ale/powershell.vim so that it can be used by other powershell things.
  • Added powershell linter which uses powershell itself to parse a script and output any syntax errors
  • Added documentation
  • Added tests.

@zigford
Copy link
Contributor Author

zigford commented Apr 8, 2019

I think I'm failing because of the custom linting rules and those rules are conflicting with each other with how the code is currently factored. Should I refactor for the linting rules?

w0rp
w0rp requested changes Apr 9, 2019
View reviewed changes
Copy link
Member

@w0rp w0rp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I explained what the linter is saying here.

ale_linters/powershell/powershell.vim Outdated Show resolved Hide resolved
ale_linters/powershell/powershell.vim Show resolved Hide resolved
ale_linters/powershell/powershell.vim Show resolved Hide resolved
ale_linters/powershell/powershell.vim Outdated Show resolved Hide resolved
@zigford
Copy link
Contributor Author

zigford commented Apr 10, 2019

Apologies for causing all these build failures. So that I don't cause any more in future PR's, could you explain again what is going wrong now?

@w0rp
Copy link
Member

w0rp commented Apr 10, 2019

The remaining issue is that the Vim help file's list of supported tools needs to match the Markdown list.

@w0rp w0rp merged commit 2ed5310 into dense-analysis:master Apr 13, 2019
@w0rp
Copy link
Member

w0rp commented Apr 13, 2019

Cheers! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w0rp w0rp w0rp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zigford @w0rp