Csc linter #2586
Merged
Csc linter #2586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mono project does not continue development on mcs but puts all efforts in the csc compiler the csc linter is added in general it is a one to one copy and thus replacement for the mcsc linter. A small fix in the sign.vim is added which prevents error when vim is started in verbose modes especially -V15. This is caused by the fact that captured buffer not just contains SignLine format string but also filename line number and all controll flags. This is prevented by defining a separate function just capturing SignLine format which than is called with verbosity explicitly turned off.
As mono project does not continue development on mcs but puts all efforts in the csc compiler the csc linter is added in general it is a one to one copy and thus replacement for the mcsc linter. A small fix in the sign.vim is added which prevents error when vim is started in verbose modes especially -V15. This is caused by the fact that captured buffer not just contains SignLine format string but also filename line number and all controll flags. This is prevented by defining a separate function just capturing SignLine format which than is called with verbosity explicitly turned off.
As mono project does not continue development on mcs but puts all efforts in the csc compiler the csc linter is added in general it is a one to one copy and thus replacement for the mcsc linter. A small fix in the sign.vim is added which prevents error when vim is started in verbose modes especially -V15. This is caused by the fact that captured buffer not just contains SignLine format string but also filename line number and all controll flags. This is prevented by defining a separate function just capturing SignLine format which than is called with verbosity explicitly turned off.
|
I'm not sure what is wrong and from Travis logs I do fail to deduce what to change to make Travis checks running.
I have first updated my forks master to upstream master and than created from fork master a new branch to not get in conflict with the previous one. Hopefully nothing went wrong there. Stuck need help of somebody to pull me back on road. Should i do a rebase the head of my fork and thus the active feature branch, as upstream head has changed at the same time while i was introducing the changes on my feature branch? From the raw logs it seems as if something with the latest build image it tries to download seems something wrong. Not sure if i could do there something. Could it be that it fetches a work in progress image erroneously? |
As mono project does not continue development on mcs but puts all efforts in the csc compiler the csc linter is added in general it is a one to one copy and thus replacement for the mcsc linter. A small fix in the sign.vim is added which prevents error when vim is started in verbose modes especially -V15. This is caused by the fact that captured buffer not just contains SignLine format string but also filename line number and all controll flags. This is prevented by defining a separate function just capturing SignLine format which than is called with verbosity explicitly turned off.
As mono project does not continue development on mcs but puts all efforts in the csc compiler the csc linter is added in general it is a one to one copy and thus replacement for the mcsc linter. A small fix in the sign.vim is added which prevents error when vim is started in verbose modes especially -V15. This is caused by the fact that captured buffer not just contains SignLine format string but also filename line number and all controll flags. This is prevented by defining a separate function just capturing SignLine format which than is called with verbosity explicitly turned off.
As mono project does not continue development on mcs but puts all efforts in the csc compiler the csc linter is added in general it is a one to one copy and thus replacement for the mcsc linter. A small fix in the sign.vim is added which prevents error when vim is started in verbose modes especially -V15. This is caused by the fact that captured buffer not just contains SignLine format string but also filename line number and all controll flags. This is prevented by defining a separate function just capturing SignLine format which than is called with verbosity explicitly turned off.
w0rp
requested changes
Jun 16, 2019
This was referenced Jun 17, 2019
As mono project does not continue development on mcs but puts all efforts in the csc compiler the csc linter is added in general it is a one to one copy and thus replacement for the mcsc linter. A small fix in the sign.vim is added which prevents error when vim is started in verbose modes especially -V15. This is caused by the fact that captured buffer not just contains SignLine format string but also filename line number and all controll flags. This is prevented by defining a separate function just capturing SignLine format which than is called with verbosity explicitly turned off.
Aaaaaaaggggrrrrrrrr fucing echos. Can we have there a custom check report in the --linters-only test checking for unexpected echo calls outside expected locations. Thanks again i have now the test output and can continue fixing what is really improper. |
As mono project does not continue development on mcs but puts all efforts in the csc compiler the csc linter is added in general it is a one to one copy and thus replacement for the mcsc linter. A small fix in the sign.vim is added which prevents error when vim is started in verbose modes especially -V15. This is caused by the fact that captured buffer not just contains SignLine format string but also filename line number and all controll flags. This is prevented by defining a separate function just capturing SignLine format which than is called with verbosity explicitly turned off.
As mono project does not continue development on mcs but puts all efforts in the csc compiler the csc linter is added in general it is a one to one copy and thus replacement for the mcsc linter. A small fix in the sign.vim is added which prevents error when vim is started in verbose modes especially -V15. This is caused by the fact that captured buffer not just contains SignLine format string but also filename line number and all controll flags. This is prevented by defining a separate function just capturing SignLine format which than is called with verbosity explicitly turned off.
As mono project does not continue development on mcs but puts all efforts in the csc compiler the csc linter is added in general it is a one to one copy and thus replacement for the mcsc linter. A small fix in the sign.vim is added which prevents error when vim is started in verbose modes especially -V15. This is caused by the fact that captured buffer not just contains SignLine format string but also filename line number and all controll flags. This is prevented by defining a separate function just capturing SignLine format which than is called with verbosity explicitly turned off.
As mono project does not continue development on mcs but puts all efforts in the csc compiler the csc linter is added in general it is a one to one copy and thus replacement for the mcsc linter. A small fix in the sign.vim is added which prevents error when vim is started in verbose modes especially -V15. This is caused by the fact that captured buffer not just contains SignLine format string but also filename line number and all controll flags. This is prevented by defining a separate function just capturing SignLine format which than is called with verbosity explicitly turned off.
As mono project does not continue development on mcs but puts all efforts in the csc compiler the csc linter is added in general it is a one to one copy and thus replacement for the mcsc linter. A small fix in the sign.vim is added which prevents error when vim is started in verbose modes especially -V15. This is caused by the fact that captured buffer not just contains SignLine format string but also filename line number and all controll flags. This is prevented by defining a separate function just capturing SignLine format which than is called with verbosity explicitly turned off.
As mono project does not continue development on mcs but puts all efforts in the csc compiler the csc linter is added in general it is a one to one copy and thus replacement for the mcsc linter. A small fix in the sign.vim is added which prevents error when vim is started in verbose modes especially -V15. This is caused by the fact that captured buffer not just contains SignLine format string but also filename line number and all controll flags. This is prevented by defining a separate function just capturing SignLine format which than is called with verbosity explicitly turned off.
As mono project does not continue development on mcs but puts all efforts in the csc compiler the csc linter is added in general it is a one to one copy and thus replacement for the mcsc linter. A small fix in the sign.vim is added which prevents error when vim is started in verbose modes especially -V15. This is caused by the fact that captured buffer not just contains SignLine format string but also filename line number and all controll flags. This is prevented by defining a separate function just capturing SignLine format which than is called with verbosity explicitly turned off.
As mono project does not continue development on mcs but puts all efforts in the csc compiler the csc linter is added in general it is a one to one copy and thus replacement for the mcsc linter. A small fix in the sign.vim is added which prevents error when vim is started in verbose modes especially -V15. This is caused by the fact that captured buffer not just contains SignLine format string but also filename line number and all controll flags. This is prevented by defining a separate function just capturing SignLine format which than is called with verbosity explicitly turned off.
|
Ok than you very much again. |
w0rp
approved these changes
Jul 2, 2019
|
Cheers! 🍻 |
timlag1305
pushed a commit
to timlag1305/ale
that referenced
this pull request
Nov 5, 2019
* Added a new csc linter for C# code. * More output is now handled for mcsc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where are the tests? Have you added tests? Have you updated the tests? Read the
comment above and the documentation referenced in it first. Write tests!
Seriously, read
:help ale-devand write tests.Hi has been some time since adding mcsc linter meanwhile plenty has change on mono side. The mcs compiler which is utilized by mcs and mcsc linters is not further developed in favour for the csc. The latter differs in the following three points output to stdout options prefixed by / instead of - and no /syntax so no csc based counter part to the ale-cs-mcs linterr.
I start the pull request now to have Travis check if my assumption that exempt from the above everything already existent for mcsc can be reused for csc. I will need some iterations and thus let you know when ready for final review.
Besides mcsc and csc got additional pattrn to capture messages not specific to source file, which were not captured before,