Fix cflags parsing (#2510, #2265) #2590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8037f47.
I went through GCC's man page and selected flags that can safely be passed to GCC and that can be useful to syntax checking. These include: - -I/-i* include flags - preprocessor flags such as -D - -W* warning flags - -O* optimization flags - most -f options - -m arch dependent options
w0rp
requested changes
Jun 16, 2019
|
My bad. It was caused by the revert. |
w0rp
approved these changes
Jun 19, 2019
|
@0mco @davidvandebunte @ranebrown What do you think? |
|
That fixes #2265 for me. Thanks! |
|
It works for me. But since this just considered |
|
I prefer the whitelist option, because there are a lot of options that should be removed. And gcc/clang may add more unwanted options in future versions, so we would have to be more careful about that. However, we could add an option for additional whitelisted flags, which would enable easy configuring for other compilers and/or newer versions without changing the source code. |
|
Okay, I'll merge this now. Thanks for this! |
Closed
suoto
pushed a commit
to suoto/ale
that referenced
this pull request
Sep 11, 2019
…analysis#2590) * Parse CFLAGS that can be passed using a whitelist I went through GCC's man page and selected flags that can safely be passed to GCC and that can be useful to syntax checking. These include: - -I/-i* include flags - preprocessor flags such as -D - -W* warning flags - -O* optimization flags - most -f options - -m arch dependent options * Fix CFLAGS tests: -Idir is now parsed to -I dir * Added two tests for flags we want or don't want to pass. * Also check for / in addition to s:sep
timlag1305
pushed a commit
to timlag1305/ale
that referenced
this pull request
Nov 5, 2019
…analysis#2590) * Parse CFLAGS that can be passed using a whitelist I went through GCC's man page and selected flags that can safely be passed to GCC and that can be useful to syntax checking. These include: - -I/-i* include flags - preprocessor flags such as -D - -W* warning flags - -O* optimization flags - most -f options - -m arch dependent options * Fix CFLAGS tests: -Idir is now parsed to -I dir * Added two tests for flags we want or don't want to pass. * Also check for / in addition to s:sep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the cflags parsing problem I had in #2510: some filenames were passed as arguments. I believe it should fix #2265 as well.
Ping for testing: @0mco @davidvandebunte @ranebrown