Fix bug with detection of the PLT in Erlang Dialyzer #2653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, it did not detect the PLT inside the `_build` directory and would always default to the default PLT or the one from the `kerl` tool.
AntoineGagne
changed the title
w0rp
requested changes
Sep 12, 2019
| @@ -15,10 +15,10 @@ endfunction | |||
| function! ale_linters#erlang#dialyzer#FindPlt(buffer) abort | |||
| let l:plt_file = '' | |||
| let l:rebar3_profile = ale_linters#erlang#dialyzer#GetRebar3Profile(a:buffer) | |||
| let l:plt_file_directory = ale#path#FindNearestDirectory(a:buffer, '_build' . l:rebar3_profile) | |||
| let l:plt_file_directory = ale#path#FindNearestDirectory(a:buffer, '_build/' . l:rebar3_profile) | |||
There was a problem hiding this comment.
With the default value above here, this string will be '_builddefault'. Is this right?
There was a problem hiding this comment.
With the previous value, yes, it would have been _builddefault. The _build directory was missing its ending slash so I added it (it makes sense in my mind to write the profile without the slashes).
w0rp
approved these changes
Sep 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it did not detect the PLT inside the
_builddirectory andwould always default to the default PLT or the one from the
kerltool.