Add support for ink-language-server #2683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit add support for ink-language-server, which it does by largely copying and pasting from the pure-language-server PR that was merged recently. The most interesting things to note are: - ink-language-server is distributed upstream via npm, which is why we search through node_modules - With some coaxing, it can be installed globally - which is why we search for a global binary. - Ink is a funky language, and users will likely need to add initialization options. - I am not incredibly familiar with vimscript; and I may not have done some of the buffer searching correctly.
|
Hi there - is there anything I can do to help get this reviewed and/or merged? Completely understand if things are just busy and this is on the backburner, but I want to make sure it's not waiting on something else from me. 😄 |
w0rp
approved these changes
Sep 22, 2019
|
Thanks for this, and sorry for the delay. I've just been slowly going through a backlog of emails. Cheers! 🍻 |
|
No problems at all! I can imagine this project takes a lot of your time. Thank you for taking the PR, and thanks for this awesome project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for ink-language-server
This commit add support for ink-language-server, which it does by
largely copying and pasting from the pure-language-server PR that was
merged recently.
The most interesting things to note are:
search through node_modules
search for a global binary.
initialization options.
some of the buffer searching correctly.
NB: Some of the formatting tests failed for me on both master, and my feature branch. Given that they fail both places, I've decided to make this PR anyways. But, if something in this commit did break tests, I'm happy to fix them of course.