Fix #2621 - Set default build directory options #2713
Conversation
clangd and ccls require the build directory to be set when `compile_commands.json` exists in other directories. Tests are needed.
There was a problem hiding this comment.
The changes look like what I would expect for clangd. I commented out the workaround, then tried the changes in my local environment with only g:ale_c_build_dir='build' (which is a typical folder for cmake projects). My test case worked as expected. I also tried setting the option to some other directory which did not exist and my problem reproduced (as expected). At least for clangd, I believe these changes are good.
There was a problem hiding this comment.
The changes look like what I would expect for clangd. I commented out the workaround, then tried the changes in my local environment with only g:ale_c_build_dir='build' (which is a typical folder for cmake projects). My test case worked as expected. I also tried setting the option to some other directory which did not exist and my problem reproduced (as expected). At least for clangd, I believe these changes are good.
|
Apologies for dup review.. don't do reviews in GitHub often. |
w0rp
force-pushed
the
bugfix/c-lsp-build-dir-settings
branch
from
e72b269 to
1bcf3dc
Compare
clangd and ccls require the build directory to be set when
compile_commands.jsonexists in other directories.Tests are needed.