Run ESLint from project root dir where possible #2937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESLint 6 loads all plugins/configs/parsers relative to the project root which, by default, is the directory in which ESLint is invoked, as described in [ESLint RFC 2018-simplified-package-loading]. Therefore, ALE should run ESLint from the project root, when possible, so that dependencies will load. This commit does so. [ESLint RFC 2018-simplified-package-loading]: https://github.com/eslint/rfcs/blob/master/designs/2018-simplified-package-loading/README.md Fixes: dense-analysis#2787 Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
w0rp
approved these changes
Jan 1, 2020
|
Cheers! 🍻 |
|
If not, feel free to ping me and I'll take another shot at it. Thanks for reviewing and merging. 🍻 |
|
Lint is working in my project but fix isn't, after debugging I found that this change should also be included in the eslint fixer for it to properly work in my project. |
joeldodge79
reviewed
Jul 1, 2020
| " Identify project root from presence of node_modules dir. | ||
| " Note: If node_modules not present yet, can't load local deps anyway. | ||
| let l:modules_dir = ale#path#FindNearestDirectory(a:buffer, 'node_modules') | ||
| let l:project_dir = !empty(l:modules_dir) ? fnamemodify(l:modules_dir, ':h:h') : '' |
There was a problem hiding this comment.
@kevinoid - for better or worse I'm in a monorepo (using Yarn Workspaces) that has the eslint stuff at the repo root but each "package" has its own package.json and node_modules/ as well (for other dependencies, they just don't have eslint). see my comment here
seems like this line is cd'ing me into the wrong directory. I wonder if we could change the logic to use the modules_dir that has the executable defined as the project dir?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #2787, ESLint 6 loads all plugins/configs/parsers relative to the project root which, by default, is the directory in which ESLint is invoked, as described in ESLint RFC 2018-simplified-package-loading.
Therefore, ALE should run ESLint from the project root, when possible, so that dependencies will load. This PR makes the change to do so.
Fixes: #2787
Thanks for reviewing,
Kevin