Allow popup to be used instead of preview in completeopt #2942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is such a minor change, I haven't added any tests. |
w0rp
approved these changes
Jan 1, 2020
|
Nice and simple. Cheers! 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some language servers send additional info (e.g. documentation, see #2905) along with auto-completion which is displayed in a preview window or not displayed at all, depending on whether
previewis present incompleteopt. For certain language severs (e.g.pyls), thepreviewoption causes the window content to move which is very annoying (see #2463). However, the user may still want to see the extra info by using thepopupoption forcompleteopt, but sincecompleteoptis overwritten byALEbefore calling the auto-complete, this is not currently possible. This PR makesALErespect thepopupsetting if the user has set it.