Keep -iframework if present in parsed C/C++ flags #3057
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-iframework
appears to implicitly add some header search paths to theset specified using the
-isystem
,-I
, and-isysroot
flags. This meansthat leaving out
-iframework
can result in invalid errors beingdisplayed.
For example, given a CMake project with this CMakeLists.txt:
and foo.cpp:
If
g:ale_c_parse_compile_commands
is set, then ALE executes somethingalong these lines:
Resulting in this output:
Because the header is in a subdirectory of the path denoted by -isystem
(/usr/local/opt/qt5/lib/QtWidgets.framework/Headers/5.14.1/QtWidgets/qtwidgetsglobal.h),
clang fails to find it and exits.
If -iframework is included, ALE executes something along these lines:
And compilation completes successfully.