Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(javac): Add java_javac_sourcepath variable #3173

Merged
merged 5 commits into from
May 19, 2020

Conversation

nibocn
Copy link
Contributor

@nibocn nibocn commented May 15, 2020

This variable can set multiple source code paths, the source code path is a relative path (relative to the project root directory)

nibocn added 2 commits May 15, 2020 10:48
This variable can set multiple source code
paths, the source code path is a relative
path (relative to the project root directory)
Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The classpath variable works with a string instead of an array. For consistency I think would be good to make this new but related variable too a string or even better make both variables classpath and sourcepath support both strings and arrays.

@nibocn
Copy link
Contributor Author

nibocn commented May 17, 2020

The classpath variable works with a string instead of an array. For consistency I think would be good to make this new but related variable too a string or even better make both variables classpath and sourcepath support both strings and arrays.

Okay, I will adjust the sourcepath variable to string later

Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement on javac configuration.

@hsanson
Copy link
Contributor

hsanson commented May 19, 2020

@nibocn Are you planning more changes? if not I can merge this change.

@nibocn
Copy link
Contributor Author

nibocn commented May 19, 2020

@hsanson That's all, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants