-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ale_linters/phpcs): add support for multiline error messages #3282
Conversation
b0f8a04
to
c86519a
Compare
Unrelated test error at |
This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See |
Rebasing seems to have fixed tests, as it was unrelated. cc / @w0rp |
This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See |
@w0rp could you please point someone to review this PR? I'm not quite sure what else I could've done here. Tests passed and all... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is all good, I've just been too busy to look at ALE pull requests in recent months.
Cheers! 🍻 |
This PR adds support for
phpcs
when there are errors resulting on messages containing more than one line.An example would be :
Before this fix, the command below would return an error, but Ale wouldn't catch it.