Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Laravel Pint #4238

Merged
merged 6 commits into from
Jul 7, 2022
Merged

Add support for Laravel Pint #4238

merged 6 commits into from
Jul 7, 2022

Conversation

michaeldyrynda
Copy link
Contributor

This PR introduces fixer support for Laravel Pint 🍺

Pint is a self-contained superset of PHP-CS-Fixer, with an opinionated set of defaults, and minimal configuration.

Think Prettier, but for Laravel projects.

@michaeldyrynda
Copy link
Contributor Author

Hey @w0rp, anything I can do to get this PR moving along?

@hsanson
Copy link
Contributor

hsanson commented Jul 6, 2022

Tests are not passing:

  Starting Vader: C:\testplugin\test\fixers\test_pint_fixer.vader
    (1/5) [EXECUTE] project with pint should use local by default
    (2/5) [EXECUTE] use-global should override local detection
    (2/5) [EXECUTE] (X) 'php-cs-fixer' should be equal to 'pint'
    (3/5) [EXECUTE] project without pint should use global
    (3/5) [EXECUTE] (X) 'php-cs-fixer' should be equal to 'pint'
    (4/5) [EXECUTE] The pint callback should return the correct default values
    (4/5) [EXECUTE] (X) {'read_temporary_file': 1, 'command': 'php-cs-fixer  %t'} should be equal to {'read_temporary_file': 1, 'command': 'pint  %t'}

Once those are fixed we can review.

@michaeldyrynda
Copy link
Contributor Author

Once those are fixed we can review.

I'll take another look at it. When i ran ./run-tests locally they seemed to just hang

❯ ./run-tests
Docker run image denseanalysis/ale:1dc2ab208994add9ed72d9d7d9186eeb ready
WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested
Starting Vim: neovim-v0.2.0...
Starting Vim: neovim-v0.6.1...
Starting Vim: vim-v8.0.0027...
Starting Vim: vim-v8.2.4693...
Starting Vint...
Starting Custom checks...

It just sits at that last line with no output or feedback. I'll let it run longer and see how it goes. Running this on an M1 Pro Mac fwiw.

@michaeldyrynda
Copy link
Contributor Author

michaeldyrynda commented Jul 7, 2022

Ok, I didn't wait long enough. Will get it sorted!

@michaeldyrynda
Copy link
Contributor Author

Got it fixed @hsanson - had a bad copy paste from the php-cs-fixer test.

hsanson
hsanson previously approved these changes Jul 7, 2022
Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.

@hsanson hsanson dismissed their stale review July 7, 2022 05:08

Still some linter tests are not passing.

doc/ale-php.txt Outdated Show resolved Hide resolved
@hsanson hsanson merged commit ad2f75e into dense-analysis:master Jul 7, 2022
cyyever pushed a commit to cyyever/ale that referenced this pull request Jul 11, 2022
* add support, docs, tests for Laravel Pint

* fix php-cs-fixer link

* add missing project-without-pint

* fix indentation

* fix pint executable in pint fixer test

* fix variables, docs related to pint support
cyyever pushed a commit to cyyever/ale that referenced this pull request Jul 11, 2022
* add support, docs, tests for Laravel Pint

* fix php-cs-fixer link

* add missing project-without-pint

* fix indentation

* fix pint executable in pint fixer test

* fix variables, docs related to pint support
mnikulin pushed a commit to mnikulin/ale that referenced this pull request Nov 12, 2023
* add support, docs, tests for Laravel Pint

* fix php-cs-fixer link

* add missing project-without-pint

* fix indentation

* fix pint executable in pint fixer test

* fix variables, docs related to pint support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants