Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #734 #998

Merged
merged 1 commit into from
Oct 15, 2017
Merged

Fix issue #734 #998

merged 1 commit into from
Oct 15, 2017

Conversation

svanharmelen
Copy link
Contributor

Fixes #734

The main issue was not consistently using the correct buffer.

Fix issue #734
090f8a8 
Fixes #734

The main issue was not consitently using the correct buffer.
@svanharmelen svanharmelen mentioned this pull request Oct 15, 2017
Closed
w0rp
w0rp approved these changes Oct 15, 2017
View reviewed changes
Copy link
Member

@w0rp w0rp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. 👍 I'll merge this now. Maybe I can come up with some tests for it later.

@w0rp w0rp merged commit a790077 into dense-analysis:master Oct 15, 2017
@w0rp
Copy link
Member

w0rp commented Oct 15, 2017

Cheers! 🍻

@svanharmelen
Copy link
Contributor Author

Thanks! 👍

@svanharmelen svanharmelen deleted the b-fix-734 branch October 15, 2017 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w0rp w0rp w0rp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svanharmelen @w0rp