Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting MediaEntryStatus in MediaEntryList to allow null values #2

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

MikiDylewski
Copy link

@MikiDylewski MikiDylewski commented Dec 19, 2022

Reason for the PR:
When user adds custom list it's status becomes null, or rather is not in the enum. Because of that #GetUserEntryCollectionAsync() throws and error that it cannot be parsed.

To test that can be null click here

To reproduce simply:

await _client.GetUserEntryCollectionAsync(165049, MediaType.Anime, new AniPaginationOptions(1, 500))

No tests were written as no core changes were made

@dentolos19
Copy link
Owner

Thanks for the fix! Will release this as soon as possible.

@dentolos19 dentolos19 merged commit d8f8bfe into dentolos19:main Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants