Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved README with screenshots #120 #121

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

improved README with screenshots #120 #121

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 26, 2017

added screenshots and changed formating of options #120

@zchee
Copy link
Member

zchee commented Apr 27, 2017

@blumentritt-sebastian LGTM, thanks!!
/cc @blueyed @tweekmonster

@tweekmonster
Copy link
Collaborator

Looks fine to me. A small nitpick: could you make the image widths the same size?

@blueyed
Copy link
Collaborator

blueyed commented Apr 29, 2017

This adds quite some overhead to the repo itself (152.0KiB, but still).

Maybe this should go into a separate gh-pages repo?!

The OP has been deleted by now btw?!

@tweekmonster
Copy link
Collaborator

This adds quite some overhead to the repo itself (152.0KiB, but still).

I didn't notice that! Yeah that overhead is unnecessary. What I usually do is drag the images into a comment field and use the URL generated instead of adding images to the repo.

@Shougo
Copy link
Collaborator

Shougo commented May 8, 2017

The user seems be deleted.
We should merge it?

@zchee
Copy link
Member

zchee commented May 24, 2017

@tweekmonster @blueyed @Shougo Sorry for the late reply.
ditto #119 (comment). This pull request is great.
I want to merge it and fix(or move separate repo or AWS s3) README.
But if we have assets file on git log, still have some overhead for fetch? (I don't know git internal architecture)

@blueyed
Copy link
Collaborator

blueyed commented May 24, 2017

@zchee
This should do it - and you should rebase/squash it, so that the asset file itself never goes to Git's history, of course.

What I usually do is drag the images into a comment field and use the URL generated instead of adding images to the repo.

@Shougo
Copy link
Collaborator

Shougo commented Sep 28, 2017

Why it is suspended?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants