Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

430 - Remove undesirable heading element #1948

Merged
merged 2 commits into from
Mar 7, 2024
Merged

430 - Remove undesirable heading element #1948

merged 2 commits into from
Mar 7, 2024

Conversation

nicksayre
Copy link
Contributor

@nicksayre nicksayre commented Mar 6, 2024

Summary

Removes an undesired heading element. Affected text should instead match as regular body copy.

I work for the IIR Team. We are the owners of Resources For Schools.

Related issue(s)

Related to vagov-content PR #925.

Testing done

This static site does not have testing.

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Before (Links are wrapped in H4s):
Screenshot 2024-03-06 at 3 44 20 PM
After (Links match regular body copy style):
Screenshot 2024-03-06 at 3 43 44 PM

What areas of the site does it impact?

Only effects Resources For Schools (https://www.va.gov/school-administrators/).

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

@va-vfs-bot va-vfs-bot temporarily deployed to master/main/ns/430-cleanup March 6, 2024 21:50 Inactive
@nicksayre nicksayre marked this pull request as ready for review March 6, 2024 21:53
@nicksayre nicksayre requested review from a team as code owners March 6, 2024 21:53
Copy link
Contributor

@maxx1128 maxx1128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small additional changes and it looks good to me.

src/site/components/merger-social-sco.html Outdated Show resolved Hide resolved
src/site/components/merger-social-sco.html Outdated Show resolved Hide resolved
@Andrew565
Copy link
Contributor

PR has requested changes, opting not to review at this time. - Tier 2/FE CoP

@nicksayre nicksayre requested a review from maxx1128 March 7, 2024 15:40
@nicksayre nicksayre merged commit f5de078 into main Mar 7, 2024
22 checks passed
@nicksayre nicksayre deleted the ns/430-cleanup branch March 7, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants