#117 PyPDF2 deprecation #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replaced references of pypdf2 with pypdf
babyjunior56
added
dependencies
cris-oddball
previously requested changes
Aug 8, 2023
|
Removed sprint and Notify label from this PR - these should not be added to PRs. |
* restored the original code for: from markupsafe import Markup
EvanParish
reviewed
Aug 8, 2023
EvanParish
reviewed
Aug 8, 2023
* fixed a code quality failure
* added dependency markupsafe to setup.py to address a warning we are getting that would prevent flask from being upgraded to >=2.4
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
cris-oddball
requested changes
Aug 8, 2023
typo in setup.py
kalbfled
reviewed
Aug 8, 2023
kalbfled
requested changes
Aug 8, 2023
* unpinning the markup + alphabetic order
cris-oddball
approved these changes
Aug 8, 2023
kalbfled
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaced references of pypdf2 with pypdf
Description
Removed all references of pypdf2 with pypdf and installs the latest version.
This also swaps:
from flask import Markup
for
from markupsafe import Markup
because the former was generating warnings that were generating warnings in the unit tests.
#117
Type of change
How Has This Been Tested?
Ran all util test cases.
================ 1365 passed, 76 skipped, 41 xfailed in 20.81s =================
Checklist