Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3798-Binny-TalkbackIssueWithHomepage #3965

Merged
merged 3 commits into from
Oct 12, 2022

Conversation

dumathane
Copy link
Contributor

@dumathane dumathane commented Oct 11, 2022

Description of Change

Fixed this, because of that line, for some reason...

Screenshots/Video

screen-20221011-193406.2.mp4

Testing

Reviewer Validations

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

@dumathane
Copy link
Contributor Author

#562 is the originator of the switch to VA Scroll View and the accessibility stuff existed even before then...is it possible this screen has always been broken in this way? That seems incredibly unlikely.

@dumathane dumathane merged commit de481e6 into develop Oct 12, 2022
@dumathane dumathane deleted the 3798-Binny-TalkbackIssueWithHomepage branch October 12, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants