Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add retries for yarn install in build jobs #7218

Merged
merged 5 commits into from
Nov 8, 2023
Merged

Add retries for yarn install in build jobs #7218

merged 5 commits into from
Nov 8, 2023

Conversation

theodur
Copy link
Contributor

@theodur theodur commented Nov 7, 2023 •
edited
Loading

Description of Change

Adds retires for installing dependencies in build jobs. It seems that npm recently removing the node-gyp binary is intermittently causing issues when installing dependencies in CI, so this should prevent us from needing to rerun the fail jobs.

Screenshots/Video

Testing

Tested in on demand build:
https://github.com/department-of-veterans-affairs/va-mobile-app/actions/runs/6790629618

  • Tested on iOS
  • Tested on Android

Reviewer Validations

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

@theodur theodur mentioned this pull request Nov 7, 2023
Closed
@theodur theodur marked this pull request as ready for review November 7, 2023 21:56
@theodur theodur requested a review from a team as a code owner November 7, 2023 21:56
@theodur theodur requested review from timwright12, narin, alexandec, TimRoe, dumathane and Sparowhawk and removed request for a team November 7, 2023 21:56
@theodur theodur merged commit 427d45e into develop Nov 8, 2023
11 checks passed
@theodur theodur deleted the feature/7188-theo-yarn-install-retries branch November 8, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandec alexandec alexandec approved these changes

@timwright12 timwright12 timwright12 approved these changes

@narin narin Awaiting requested review from narin narin is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@TimRoe TimRoe Awaiting requested review from TimRoe TimRoe is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@dumathane dumathane Awaiting requested review from dumathane dumathane is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@Sparowhawk Sparowhawk Awaiting requested review from Sparowhawk Sparowhawk is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theodur @timwright12 @alexandec