[AP] In progress event is not at the top on Event Detail pages

[randimays]

Description

Slack thread for context: https://dsva.slack.com/archives/C07B86KV4P4/p1727981916287789

Events in progress should appear at the top of Event Detail pages until the event time has passed. This should apply for both:

• Events with recurrences
• Events without recurrences

Example AP URL: https://dev.va.gov/detroit-health-care/events/68589/
Example Prod URL: https://va.gov/detroit-health-care/events/68589/

Why this is happening: https://dsva.slack.com/archives/C52CL1PKQ/p1660681413087369?thread_ts=1660266788.151129&cid=C52CL1PKQ
So, the decision we made in Next Build was, pull all the events for an event listing page, past and future, and put them in the page as one bucket. However, and this is key, when the user views the page, it looks at the timing of the user's browser, and it does that division of future and past on the fly.
It is possible there is an issue with the logic there, definitely. But we were looking at a situation where, in a hypothetical future state, an event listing might not be published for several days, because there's no reason to do it. So what is past and what is future would change. We wanted that to be dynamic and tied to the user's action, not for that decision to be made at time of page creation.

Note: Troubleshooting this ticket requires finding an event that is currently in progress. The event above may or may not be currently in progress when this ticket is worked.

Testing & QA

• For an event that has recurrences, the event currently happening should be at the top of the event detail page until the event has ended for the day, and also in the "other times" accordion at the bottom of the page.
• For an event that does not have recurrences, the event currently happening should be at the top of the event detail page until the event has ended for the day.
• The testing is outlined on the PR: Check for ongoing recurring events when making date-based event calculations. next-build#795. Testing is all on Tugboat. (from Tim C in a comment below).

Roles / assignments

After functional testing, code review, accessibility review, and design review can happen in parallel.

• Functional testing: AP team and @randimays
• Code review: AP team or @randimays
• Product acceptance: @FranECross

Acceptance criteria

• Events in progress appear at the top of the Event Detail page until event time is complete (either end of day or end of event time, pending technical lift)
• Events with recurrences have all recurrences in the "other times" accordion at the bottom of the page
• Events without recurrences still show the correct time as expected

[randimays]

Moved to Current Sprint, Not Started for visibility as this should be launch-blocking, but have not yet fleshed out the ACs / testing info, so it still has the "Needs refining" label on it.

[jilladams]

Determined this is launch blocking for Event LIstings, but not for Event Detail Pages:
https://dsva.slack.com/archives/C07B86KV4P4/p1728318556408759?thread_ts=1728062069.765979&cid=C07B86KV4P4

• Once we confirm no other launch blocking issues: let's ship Event Detail Pages.
• Let's hold Event Listings. Since AP won't be officially staffed by CMS team and Sitewide will own the events logic long term: Sitewide will file a bug, we can own working out the logic fix / work with Tim to understand what happened before / what should happen next.

So: Pulling this out of Sprint 14, so we can refine. This will require ramp up for someone to get familiar with the decisions in AP logic, in order to revise them, and that should factor into points.

[randimays]

@ttran-Therisa I updated the ticket body here to note that this ticket is specifically for event detail pages, not event listings (search results). For both events with and without recurrences, the currently happening event should be at the top of the page.

This defect has been discussed extensively in Slack:

• https://dsva.slack.com/archives/C07B86KV4P4/p1728062069765979
• https://dsva.slack.com/archives/C07B86KV4P4/p1727981916287789

but if there's any confusion about functionality / expectation please ping; happy to help.

[randimays]

@ttran-Therisa Also wanted to point out that I had reported in the QA spreadsheet that in the "other times" accordion at the bottom of the page in AP, there are only 5 events showing (before the Show all button is clicked) when in prod there are 6 events showing. I think this is simply a < versus <= in the logic, but I just wanted to flag there here in case it has deeper ramifications.

Line 46 -> https://docs.google.com/spreadsheets/d/1czCFV4d4rQXcxoxVYoWtVyfSNGTDChhYchLLsxmp3OY/edit?gid=675750633#gid=675750633

[FranECross]

@jilladams Should I remove the Public Websites tag since we won't be working on this ticket? Thanks.

[jilladams]

IMO: let's leave it on for a bit in case Tim gets slammed and needs to hand it back.

[gracekretschmer-metrostar]

@jilladams @FranECross Tim has the work completed and is now prepping for testing, which we will need support from sitewide team to complete.

[jilladams]

Great - just let us know where the environment is for testing -- is it on dev.va.gov?

[gracekretschmer-metrostar]

As on 10/23 Randi, has done some testing, but Grace will confirm timelines during today's sitewide sync.

[timcosgrove]

Great - just let us know where the environment is for testing -- is it on dev.va.gov?

Apologies for not responding sooner. The testing is outlined on the PR: department-of-veterans-affairs/next-build#795

Testing is all on Tugboat.