Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNM: Integration form engine 2 #19123

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

DNM: Integration form engine 2 #19123

wants to merge 6 commits into from

Conversation

ryguyk
Copy link
Contributor

@ryguyk ryguyk commented Sep 5, 2024

DO NOT MERGE

Description

Relates to #issueid. (or closes?)

Individual PRs:

Testing done

Screenshots

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

As user uid with user_role

  1. Do this
    • Validate that
  2. Then
    • Validate that
  3. Then validate Acceptance Criteria from issue
    • a
    • b
    • c

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 5, 2024 18:56 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 13, 2024 20:02 Destroyed
derekhouck and others added 5 commits September 16, 2024 11:12
* Add Digital Form content type

* Update Digital Form description

---------

Co-authored-by: Derek Houck <derekhouck@Derek-Houck.local>
* WIP: Create digital form script

* Add steps

* Rename exit_if_wrong_env
* Add create_digital_forms

* Add 21-4140 to digital forms script

* Switch includeDob to snake case
* Add OMB info fields to Digital Form (#19078)

* Add Identification Information pattern

* Add OMB Info to digital-forms script

* Add Identification Information to digital-forms script
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 17, 2024 12:37 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 18, 2024 08:39 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 19, 2024 08:41 Destroyed
@va-cms-bot
Copy link
Collaborator

va/tests/status-error:


entity_update
Title Entity/field definitions
Severity Error
Sid 2
Description The following changes were detected in the entity type and field definitions.
.... Message

         * The /Changed/ field needs to be uninstalled.                               

Value Mismatched entity and/or field definitions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants