Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-19128: adding patch for eca module #19129

Merged
merged 5 commits into from
Oct 2, 2024

Conversation

edmund-dunn
Copy link
Contributor

Description

Closes #19128

Adding patch to ECA module to fix instantiation error.

Testing done

Screenshots

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

If this passes automated testing it is good to go.

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@edmund-dunn edmund-dunn linked an issue Sep 5, 2024 that may be closed by this pull request
2 tasks
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 5, 2024 21:27 Destroyed
@github-actions github-actions bot added the CMS Team CMS Product team that manages both editor exp and devops label Sep 5, 2024
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 13, 2024 15:38 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 18, 2024 08:40 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 19, 2024 08:41 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 20, 2024 08:40 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 21, 2024 08:36 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 22, 2024 08:35 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 23, 2024 08:34 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 24, 2024 08:46 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 25, 2024 08:36 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 26, 2024 08:39 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 27, 2024 08:39 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 28, 2024 08:39 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 29, 2024 08:37 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 30, 2024 08:36 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 1, 2024 08:32 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 1, 2024 08:41 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 2, 2024 08:35 Destroyed
@gracekretschmer-metrostar

Confirming with Edmund about if this work was completed.

@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 2, 2024 14:37 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 2, 2024 17:55 Destroyed
Copy link
Contributor

@JakeBapple JakeBapple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 2, 2024 18:18 Destroyed
@edmund-dunn edmund-dunn enabled auto-merge (squash) October 2, 2024 18:21
@edmund-dunn edmund-dunn merged commit 319490d into main Oct 2, 2024
18 checks passed
@edmund-dunn edmund-dunn deleted the 19128-patch-eca-contrib-module-to-fix-error branch October 2, 2024 18:52
keisterj-oddball pushed a commit that referenced this pull request Oct 4, 2024
* VACMS-19128: adding patch for eca module

* VACMS-19128: updated composer.log
keisterj-oddball pushed a commit that referenced this pull request Oct 4, 2024
* VACMS-19128: adding patch for eca module

* VACMS-19128: updated composer.log
keisterj-oddball pushed a commit that referenced this pull request Oct 4, 2024
* VACMS-19128: adding patch for eca module

* VACMS-19128: updated composer.log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMS Team CMS Product team that manages both editor exp and devops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Patch ECA contrib module to fix error
4 participants