-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VACMS-17862: Moves VACMS facility Mental health phone number from field to paragraph #19234
Merged
dsasser
merged 14 commits into
VACMS-17854-integration-phone-number-migrations
from
VACMS-17862-makes-mental-health-phone-paragraph
Sep 24, 2024
Merged
VACMS-17862: Moves VACMS facility Mental health phone number from field to paragraph #19234
dsasser
merged 14 commits into
VACMS-17854-integration-phone-number-migrations
from
VACMS-17862-makes-mental-health-phone-paragraph
Sep 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omahane
force-pushed
the
VACMS-17862-makes-mental-health-phone-paragraph
branch
from
September 17, 2024 22:57
4b5d3b4
to
d9dd19e
Compare
omahane
changed the title
VACMS-17862: Moves VACMS facility from field to paragraph
VACMS-17862: Moves VACMS facility Mental health phone number from field to paragraph
Sep 17, 2024
omahane
force-pushed
the
VACMS-17862-makes-mental-health-phone-paragraph
branch
from
September 18, 2024 18:11
93b43b3
to
941f7de
Compare
omahane
force-pushed
the
VACMS-17862-makes-mental-health-phone-paragraph
branch
from
September 18, 2024 18:27
5956dd3
to
1c29f0b
Compare
omahane
force-pushed
the
VACMS-17862-makes-mental-health-phone-paragraph
branch
from
September 18, 2024 18:30
1c29f0b
to
6a2ca7f
Compare
omahane
force-pushed
the
VACMS-17862-makes-mental-health-phone-paragraph
branch
from
September 18, 2024 18:37
6a2ca7f
to
185f82c
Compare
omahane
force-pushed
the
VACMS-17862-makes-mental-health-phone-paragraph
branch
from
September 18, 2024 18:45
185f82c
to
462e022
Compare
omahane
force-pushed
the
VACMS-17862-makes-mental-health-phone-paragraph
branch
from
September 18, 2024 18:47
462e022
to
723ab4f
Compare
omahane
force-pushed
the
VACMS-17862-makes-mental-health-phone-paragraph
branch
from
September 18, 2024 18:50
723ab4f
to
a5c4d34
Compare
github-actions
bot
added
the
Facilities
Facilities products (VAMC, Vet Center, etc)
label
Sep 18, 2024
va/tests/status-error:
|
omahane
force-pushed
the
VACMS-17854-integration-phone-number-migrations
branch
from
September 23, 2024 16:44
cfa3243
to
5efde21
Compare
omahane
force-pushed
the
VACMS-17862-makes-mental-health-phone-paragraph
branch
from
September 23, 2024 16:52
dce810d
to
390de2e
Compare
omahane
force-pushed
the
VACMS-17862-makes-mental-health-phone-paragraph
branch
from
September 23, 2024 17:15
390de2e
to
4bb3c93
Compare
dsasser
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -4233,11 +4234,11 @@ display: | |||
group_type: group | |||
admin_label: '' | |||
plugin_id: field | |||
label: 'Staff Profile Phone' | |||
label: 'Staff profile, Mental health (VAMC facility), or Billing and insurance phone' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks for adding updating this for all 3 issues!
dsasser
merged commit Sep 24, 2024
fc1c56c
into
VACMS-17854-integration-phone-number-migrations
26 checks passed
dsasser
added a commit
that referenced
this pull request
Oct 16, 2024
* VACMS-17860: Updates staff phone field to paragraph field (#19038) * VACMS-17860: Adds migration for phone to telephone paragraph for Staff profile content type. * VACMS-17860: Adds codit_batch_operations to codebase. * VACMS-17860: Adds va_gov_batch, tests, and updated CODEOWNERS. * VACMS-17860: Replaces bespoke batch operation with a BatchOperations class. * VACMS-17860: Adds new telephone paragraph field to staff profile. * VACMS-17860: Fixes the phone validation and parsing. * VACMS-17860: Avoids unefined array index warnings. * VACMS-17860: Removes unused method * VACMS-17860: Remove batching configuration in our class because it is already setup in codit. * VACMS-17860: Ensures old phone is not shown on edit form. * VACMS-17860: Fixes extension migration. * VACMS-17860: Updates phone audit view with new phone number paragraph field for staff profile. * VACMS-17860: Restores revision log on staff profile form. * VACMS-17860: Updates cypress test. * VACMS-17860: Fixes typo in CODEOWNERS. * VACMS-17860: PHPCS fix. * VACMS-17860: Fixes selector in cypress test. * VACMS-17861: Minor updates to deploy script. * VACMS-17860: PHPCS fix. * VACMS-17860: Updates nginx config to allow for a larger returned response header. This is necessary when Drupal responsds with a very large cache-context payload. * VACMS-17860: Removes access to the phone label rather than hiding it to prevent php error. * VACMS-17860: Updates nginx config to align with latest ddev default config for D10. * VACMS-17854: Updates composer.lock * VACMS-17862: Moves VACMS facility Mental health phone number from field to paragraph (#19234) * VACMS-17862: Adds configuration changes and script to migrating phones * VACMS-17862: Updates the phone number audit view * VACMS-17862: Adds data push changes for mental health * VACMS-17862: Updates the mental health data push code. * VACMS-17862: Accounts for no mental health paragraph * VACMS-17862: Update node and view config * VACMS-17862: Restores revision_log * VACMS-17862: Adds step for filling mental health phone * VACMS-17862: Adds deploy hook and data bypass * VACMS-17862: Fixes path to script-library * VACMS-17862: Add help text * VACMS-17854: Updates composer.lock * Revert "VACMS-17854: Updates composer.lock" This reverts commit 4bb3c93. * Updates the deploy, removing the new one * VACMS-17860: Removes deploy script for Staff Profile telephone migration (#19308) * VACMS-17860: Removes deploy hook for Staff Profile telephone field migration in order to manually perform the migration via drush using codit's drush command. --------- Co-authored-by: Christian Burk <omahane@gmail.com> * VACMS-17861: Replace VAMC Billing and Insurance telephone field with telephone paragraph (#19264) * VACMS-17860: Updates staff phone field to paragraph field (#19038) * VACMS-17860: Adds migration for phone to telephone paragraph for Staff profile content type. * VACMS-17860: Adds codit_batch_operations to codebase. * VACMS-17860: Adds va_gov_batch, tests, and updated CODEOWNERS. * VACMS-17860: Replaces bespoke batch operation with a BatchOperations class. * VACMS-17860: Adds new telephone paragraph field to staff profile. * VACMS-17860: Fixes the phone validation and parsing. * VACMS-17860: Avoids unefined array index warnings. * VACMS-17860: Removes unused method * VACMS-17860: Remove batching configuration in our class because it is already setup in codit. * VACMS-17860: Ensures old phone is not shown on edit form. * VACMS-17860: Fixes extension migration. * VACMS-17860: Updates phone audit view with new phone number paragraph field for staff profile. * VACMS-17860: Restores revision log on staff profile form. * VACMS-17860: Updates cypress test. * VACMS-17860: Fixes typo in CODEOWNERS. * VACMS-17860: PHPCS fix. * VACMS-17860: Fixes selector in cypress test. * VACMS-17861: Minor updates to deploy script. * VACMS-17860: PHPCS fix. * VACMS-17860: Updates nginx config to allow for a larger returned response header. This is necessary when Drupal responsds with a very large cache-context payload. * VACMS-17860: Removes access to the phone label rather than hiding it to prevent php error. * VACMS-17860: Updates nginx config to align with latest ddev default config for D10. * VACMS-17854: Updates content-hash * VACMS-17861: Adds telephone field to VAMC Billing and Insurance content type. - Adds migration to move from old field to new paragraph. * VACMS-17861: Removed unwanted deploy hook. * VACMS-17861: Fixing branch rebase issues * VACMS-17861: Ensures old phone number is no longer displayed. * VACMS-17861: Hides phone label using existing method. * VACMS-17861: Resores missing revision_log. --------- Co-authored-by: Christian Burk <omahane@gmail.com> Co-authored-by: Jerry Vrabel <jerry.vrabel@agile6.com> * VACMS-17854: Fix phpstan warnings. * VACMS-17854: Updates function calls with correct type * VACMS-17854: Fix phpstan warnings. (#19362) * VACMS-17854: Fix phpstan warnings. * VACMS-17854: Updates function calls with correct type --------- Co-authored-by: Christian Burk <omahane@gmail.com> * VACMS-17854: Merges main and updates composer lock * VACMS-17854: Add feature toggle to display old/new telephone fields conditionally (#19472) * VACMS-17854: Adds telephone migration audit View. * VACMS-17854: Adds feature toggle for telephone migration. * VACMS-17854: Show both telephone fields on Staff Profile content type form. * VACMS-17854: Show both telephone fields on VAMC Facility Billing and Insurance content type form * VACMS-17854: Show both telephone fields on VAMC Facility content type form. * VACMS-17854: Put telephone fields behind feature toggle for Staff Profile content type. * VACMS-17854: Leverage feature toggle to return correct phone for a VAMC Facility in posts into Lighthouse. * VACMS-17854: Put telephone field behind feature toggle for VAMC System Billing and Insurand and VAMC Facility content types. * VACMS-17854: Remove test validations introduced in ealier commits. These can be added back after the telephone migration is complete. * VACMS-18163: Adds new 'How to Apply' field to Benefits taxonomy (#19445) * VACMS-18163: BenefitTaxonomy four configs for how to apply * VACMS-18163: Added- revision_log_message to group_va_benefit_workflow * VACMS-18163: changes to config for field translation * VACMS-18163: Manual addition of - revision_log_message * Bump va-gov/content-build from 0.0.3611 to 0.0.3612 (#19487) Bumps [va-gov/content-build](https://github.com/department-of-veterans-affairs/content-build) from 0.0.3611 to 0.0.3612. - [Release notes](https://github.com/department-of-veterans-affairs/content-build/releases) - [Commits](department-of-veterans-affairs/content-build@v0.0.3611...v0.0.3612) --- updated-dependencies: - dependency-name: va-gov/content-build dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * VACMS-17854: Adds node:view to toggle and accounts for two facility phone fields * VACMS-17854: Updates config so code can hide fields * VACMS-17854: Adds check for new facility form * VACMS-17854: Updates the logic for computers, instead of humans --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: jv-agile6 <gerald.vrabel@va.gov> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Christian Burk <omahane@gmail.com> * VACMS-17854: Fix composer.lock merge conflict resolution mistake by updating content-build to the latest release to match main. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Christian Burk <omahane@gmail.com> Co-authored-by: Jerry Vrabel <jerry.vrabel@agile6.com> Co-authored-by: jv-agile6 <gerald.vrabel@va.gov> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relates to #17862
Testing done
Manually
Screenshots
Audit
Node:edit
Node:view
QA Steps
Run the data migration
drush codit-batch-operations:run MigrateVamcFacilityMentalHealthPhoneFieldToParagraph
Set up QA Content Publisher
Note: The following are the default settings, so there's nothing to do. This is to be clear to our present and future selves about what the user's permissions are before commencing QA.
- Content creator - VAMC
- Content publisher
- Boston VA health care
Check the audit
Check a VAMC Facility
Select Team for PR review
CMS Team
Public websites
Facilities
User support
Accelerated Publishing