Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-17862: Moves VACMS facility Mental health phone number from field to paragraph #19234

Conversation

omahane
Copy link
Contributor

@omahane omahane commented Sep 17, 2024

Description

Relates to #17862

Testing done

Manually

Screenshots

Audit

Screenshot 2024-09-18 at 4 49 54 PM

Node:edit

Screenshot 2024-09-18 at 4 45 22 PM

Node:view

Screenshot 2024-09-18 at 4 46 32 PM

QA Steps

Run the data migration

  1. Go to the Tugboat terminal
  2. Run the following command: drush codit-batch-operations:run MigrateVamcFacilityMentalHealthPhoneFieldToParagraph
  3. Make a sandwich
  4. Walk the dog
  5. Clean your andirons
  6. Wait just a little bit longer
  • Confirm that the script finished running

Set up QA Content Publisher

Note: The following are the default settings, so there's nothing to do. This is to be clear to our present and future selves about what the user's permissions are before commencing QA.

  1. As an admin, update the QA Content Publisher
  2. Assign the following roles
    - Content creator - VAMC
    - Content publisher
  3. Assign the following Section
    - Boston VA health care

Check the audit

  1. As an admin, visit the Phone numbers audit, filtered for Staff Profile
  • Confirm that the numbers in the "Direct line" column are the same as the "Staff profile, Mental health (VAMC facility), or Billing and insurance phone" column (with the possibility of some exceptions)
  1. Change the content type of the filter to VAMC Facility.
  • Confirm that the numbers in the "Mental Health Phone (old)" column are the same as the "Staff profile, Mental health (VAMC facility), or Billing and insurance phone" column (with the possibility of some exceptions)

Check a VAMC Facility

  1. As QA Content Publisher, log in.
  2. Go to the Plymouth VA Clinic node:edit screen.
  • Confirm that the old Mental health phone number field is not shown
  • Confirm that the new Mental health phone number paragraph is shown
  • Confirm that the new Mental health phone number paragraph has a phone number
  1. Save the node
  • Confirm that it saves without issue
  1. Check a VAMC facility node:view
  • Confirm that the old Mental health phone number field is not shown
  • Confirm that the new Mental health phone number paragraph is shown
  • Confirm that the new Mental health phone number paragraph has a phone number

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

@omahane omahane requested review from a team as code owners September 17, 2024 22:46
@omahane omahane force-pushed the VACMS-17862-makes-mental-health-phone-paragraph branch from 4b5d3b4 to d9dd19e Compare September 17, 2024 22:57
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 17, 2024 22:57 Destroyed
@omahane omahane changed the title VACMS-17862: Moves VACMS facility from field to paragraph VACMS-17862: Moves VACMS facility Mental health phone number from field to paragraph Sep 17, 2024
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 18, 2024 08:55 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 18, 2024 15:19 Destroyed
@omahane omahane force-pushed the VACMS-17862-makes-mental-health-phone-paragraph branch from 93b43b3 to 941f7de Compare September 18, 2024 18:11
@omahane omahane force-pushed the VACMS-17862-makes-mental-health-phone-paragraph branch from 5956dd3 to 1c29f0b Compare September 18, 2024 18:27
@omahane omahane force-pushed the VACMS-17862-makes-mental-health-phone-paragraph branch from 1c29f0b to 6a2ca7f Compare September 18, 2024 18:30
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 18, 2024 18:30 Destroyed
@omahane omahane force-pushed the VACMS-17862-makes-mental-health-phone-paragraph branch from 6a2ca7f to 185f82c Compare September 18, 2024 18:37
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 18, 2024 18:37 Destroyed
@omahane omahane force-pushed the VACMS-17862-makes-mental-health-phone-paragraph branch from 185f82c to 462e022 Compare September 18, 2024 18:45
@omahane omahane force-pushed the VACMS-17862-makes-mental-health-phone-paragraph branch from 462e022 to 723ab4f Compare September 18, 2024 18:47
@omahane omahane force-pushed the VACMS-17862-makes-mental-health-phone-paragraph branch from 723ab4f to a5c4d34 Compare September 18, 2024 18:50
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 18, 2024 18:50 Destroyed
@github-actions github-actions bot added the Facilities Facilities products (VAMC, Vet Center, etc) label Sep 18, 2024
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 18, 2024 21:29 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 19, 2024 08:58 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 19, 2024 15:27 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 20, 2024 08:54 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 21, 2024 08:38 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 22, 2024 08:37 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 23, 2024 08:36 Destroyed
@omahane omahane requested a review from a team as a code owner September 23, 2024 15:07
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 23, 2024 15:07 Destroyed
@va-cms-bot
Copy link
Collaborator

va/tests/status-error:


entity_update
Title Entity/field definitions
Severity Error
Sid 2
Description The following changes were detected in the entity type and field definitions.
.... Message

         * The /Changed/ field needs to be uninstalled.                               

Value Mismatched entity and/or field definitions

@omahane omahane force-pushed the VACMS-17854-integration-phone-number-migrations branch from cfa3243 to 5efde21 Compare September 23, 2024 16:44
@omahane omahane requested a review from a team as a code owner September 23, 2024 16:44
@omahane omahane force-pushed the VACMS-17862-makes-mental-health-phone-paragraph branch from dce810d to 390de2e Compare September 23, 2024 16:52
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 23, 2024 16:52 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 23, 2024 17:23 Destroyed
Copy link
Contributor

@dsasser dsasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works great!

Staff profile telephone audit after migration:
Screenshot 2024-09-23 at 10 27 03 PM

VAMC Facility telephone audit after data migration:
Screenshot 2024-09-23 at 10 29 54 PM

VAMC Faclity node view:
Screenshot 2024-09-23 at 10 31 49 PM

@@ -4233,11 +4234,11 @@ display:
group_type: group
admin_label: ''
plugin_id: field
label: 'Staff Profile Phone'
label: 'Staff profile, Mental health (VAMC facility), or Billing and insurance phone'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks for adding updating this for all 3 issues!

@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 24, 2024 08:48 Destroyed
@dsasser dsasser merged commit fc1c56c into VACMS-17854-integration-phone-number-migrations Sep 24, 2024
26 checks passed
@dsasser dsasser deleted the VACMS-17862-makes-mental-health-phone-paragraph branch September 24, 2024 14:13
dsasser added a commit that referenced this pull request Oct 16, 2024
* VACMS-17860: Updates staff phone field to paragraph field (#19038)

* VACMS-17860: Adds migration for phone to telephone paragraph for Staff profile content type.

* VACMS-17860: Adds codit_batch_operations to codebase.

* VACMS-17860: Adds va_gov_batch, tests, and updated CODEOWNERS.

* VACMS-17860: Replaces bespoke batch operation with a BatchOperations class.

* VACMS-17860: Adds new telephone paragraph field to staff profile.

* VACMS-17860: Fixes the phone validation and parsing.

* VACMS-17860: Avoids unefined array index warnings.

* VACMS-17860: Removes unused method

* VACMS-17860: Remove batching configuration in our class because it is already setup in codit.

* VACMS-17860: Ensures old phone is not shown on edit form.

* VACMS-17860: Fixes extension migration.

* VACMS-17860: Updates phone audit view with new phone number paragraph field for staff profile.

* VACMS-17860: Restores revision log on staff profile form.

* VACMS-17860: Updates cypress test.

* VACMS-17860: Fixes typo in CODEOWNERS.

* VACMS-17860: PHPCS fix.

* VACMS-17860: Fixes selector in cypress test.

* VACMS-17861: Minor updates to deploy script.

* VACMS-17860: PHPCS fix.

* VACMS-17860: Updates nginx config to allow for a larger returned response header. This is necessary when Drupal responsds with a very large cache-context payload.

* VACMS-17860: Removes access to the phone label rather than hiding it to prevent php error.

* VACMS-17860: Updates nginx config to align with latest ddev default config for D10.

* VACMS-17854: Updates composer.lock

* VACMS-17862: Moves VACMS facility Mental health phone number from field to paragraph (#19234)

* VACMS-17862: Adds configuration changes and script to migrating phones

* VACMS-17862: Updates the phone number audit view

* VACMS-17862: Adds data push changes for mental health

* VACMS-17862: Updates the mental health data push code.

* VACMS-17862: Accounts for no mental health paragraph

* VACMS-17862: Update node and view config

* VACMS-17862: Restores revision_log

* VACMS-17862: Adds step for filling mental health phone

* VACMS-17862: Adds deploy hook and data bypass

* VACMS-17862: Fixes path to script-library

* VACMS-17862: Add help text

* VACMS-17854: Updates composer.lock

* Revert "VACMS-17854: Updates composer.lock"

This reverts commit 4bb3c93.

* Updates the deploy, removing the new one

* VACMS-17860: Removes deploy script for Staff Profile telephone migration (#19308)

* VACMS-17860: Removes deploy hook for Staff Profile telephone field migration in order to manually perform the migration via drush using codit's drush command.

---------

Co-authored-by: Christian Burk <omahane@gmail.com>

* VACMS-17861: Replace VAMC Billing and Insurance telephone field with telephone paragraph (#19264)

* VACMS-17860: Updates staff phone field to paragraph field (#19038)

* VACMS-17860: Adds migration for phone to telephone paragraph for Staff profile content type.

* VACMS-17860: Adds codit_batch_operations to codebase.

* VACMS-17860: Adds va_gov_batch, tests, and updated CODEOWNERS.

* VACMS-17860: Replaces bespoke batch operation with a BatchOperations class.

* VACMS-17860: Adds new telephone paragraph field to staff profile.

* VACMS-17860: Fixes the phone validation and parsing.

* VACMS-17860: Avoids unefined array index warnings.

* VACMS-17860: Removes unused method

* VACMS-17860: Remove batching configuration in our class because it is already setup in codit.

* VACMS-17860: Ensures old phone is not shown on edit form.

* VACMS-17860: Fixes extension migration.

* VACMS-17860: Updates phone audit view with new phone number paragraph field for staff profile.

* VACMS-17860: Restores revision log on staff profile form.

* VACMS-17860: Updates cypress test.

* VACMS-17860: Fixes typo in CODEOWNERS.

* VACMS-17860: PHPCS fix.

* VACMS-17860: Fixes selector in cypress test.

* VACMS-17861: Minor updates to deploy script.

* VACMS-17860: PHPCS fix.

* VACMS-17860: Updates nginx config to allow for a larger returned response header. This is necessary when Drupal responsds with a very large cache-context payload.

* VACMS-17860: Removes access to the phone label rather than hiding it to prevent php error.

* VACMS-17860: Updates nginx config to align with latest ddev default config for D10.

* VACMS-17854: Updates content-hash

* VACMS-17861: Adds telephone field to VAMC Billing and Insurance content type.
- Adds migration to move from old field to new paragraph.

* VACMS-17861: Removed unwanted deploy hook.

* VACMS-17861: Fixing branch rebase issues

* VACMS-17861: Ensures old phone number is no longer displayed.

* VACMS-17861: Hides phone label using existing method.

* VACMS-17861: Resores missing revision_log.

---------

Co-authored-by: Christian Burk <omahane@gmail.com>
Co-authored-by: Jerry Vrabel <jerry.vrabel@agile6.com>

* VACMS-17854: Fix phpstan warnings.

* VACMS-17854: Updates function calls with correct type

* VACMS-17854: Fix phpstan warnings. (#19362)

* VACMS-17854: Fix phpstan warnings.

* VACMS-17854: Updates function calls with correct type

---------

Co-authored-by: Christian Burk <omahane@gmail.com>

* VACMS-17854: Merges main and updates composer lock

* VACMS-17854: Add feature toggle to display old/new telephone fields conditionally (#19472)

* VACMS-17854: Adds telephone migration audit View.

* VACMS-17854: Adds feature toggle for telephone migration.

* VACMS-17854: Show both telephone fields on Staff Profile content type form.

* VACMS-17854: Show both telephone fields on VAMC Facility Billing and Insurance content type form

* VACMS-17854: Show both telephone fields on VAMC Facility content type form.

* VACMS-17854: Put telephone fields behind feature toggle for Staff Profile content type.

* VACMS-17854: Leverage feature toggle to return correct phone for a VAMC Facility in posts into Lighthouse.

* VACMS-17854: Put telephone field behind feature toggle for VAMC System Billing and Insurand and VAMC Facility content types.

* VACMS-17854: Remove test validations introduced in ealier commits. These can be added back after the telephone migration is complete.

* VACMS-18163: Adds new 'How to Apply' field to Benefits taxonomy (#19445)

* VACMS-18163: BenefitTaxonomy four configs for how to apply

* VACMS-18163: Added- revision_log_message to group_va_benefit_workflow

* VACMS-18163: changes to config for field translation

* VACMS-18163: Manual addition of - revision_log_message

* Bump va-gov/content-build from 0.0.3611 to 0.0.3612 (#19487)

Bumps [va-gov/content-build](https://github.com/department-of-veterans-affairs/content-build) from 0.0.3611 to 0.0.3612.
- [Release notes](https://github.com/department-of-veterans-affairs/content-build/releases)
- [Commits](department-of-veterans-affairs/content-build@v0.0.3611...v0.0.3612)

---
updated-dependencies:
- dependency-name: va-gov/content-build
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* VACMS-17854: Adds node:view to toggle and accounts for two facility phone fields

* VACMS-17854: Updates config so code can hide fields

* VACMS-17854: Adds check for new facility form

* VACMS-17854: Updates the logic for computers, instead of humans

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: jv-agile6 <gerald.vrabel@va.gov>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Christian Burk <omahane@gmail.com>

* VACMS-17854: Fix composer.lock merge conflict resolution mistake by updating content-build to the latest release to match main.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Christian Burk <omahane@gmail.com>
Co-authored-by: Jerry Vrabel <jerry.vrabel@agile6.com>
Co-authored-by: jv-agile6 <gerald.vrabel@va.gov>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Facilities Facilities products (VAMC, Vet Center, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants