Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-20086: Adds code for Manila VA Clinic and removes unused code. #20088

Merged
merged 4 commits into from
Dec 19, 2024

Conversation

omahane
Copy link
Contributor

@omahane omahane commented Dec 12, 2024

Description

Relates to #20086

Testing done

Manually
Cypress

Screenshots

QA steps

Set up the editor

  • Log in as an admin
  • Assign QA Content Publisher to the following roles
    • Content creator - VAMC
    • Content publisher
  • Assign QA Content Publisher to the following Sections
    • Manila Va Clinic
    • VA Pacific Islands health care

Make sure the Manila path is correct

  • Log in as QA Content Publisher

Create an Event in the Manila section

  • Choose "---Manila VA Clinic" for Section
  • Fill in all required fields
    • Try to choose a non-Manila option for the Where should the event be listed? field
  • Save as Published
    • Confirm that you cannot save the node until you choose the Manila option for the Where should the event be listed? field
  • After save, from the event node:view, confirm that the url contains "/manila-va-clinic/" after the domain
  • Edit the event
    • Save as published
  • After save, from the event node:view, confirm that the url contains "/manila-va-clinic/" after the domain

Create a Story in the Manila section

  • Choose "---Manila VA Clinic" for Section
  • Fill in all required fields
    • Initially, try to choose a non-Manila option for the Where should the story be listed? field
  • Save as Published
    • Confirm that you cannot save the node until you choose the Manila option for the Where should the story be listed? field
  • After save, from the event node:view, confirm that the url contains "/manila-va-clinic/" after the domain
  • Edit the story
  • Save as published
  • After save, from the event node:view, confirm that the url contains "/manila-va-clinic/" after the domain

Create a News Release in the Manila section

  • Choose "---Manila VA Clinic" for Section
  • Fill in all required fields
    • Initially, try to choose a non-Manila option for the News releases listing field
  • Save as Published
    • Confirm that you cannot save the node until you choose the Manila option for the News releases listing field
  • After save, from the event node:view, confirm that the url contains "/manila-va-clinic/" after the domain
  • Edit the news release
  • Save as published
  • After save, from the event node:view, confirm that the url contains "/manila-va-clinic/" after the domain

Create a Staff Profile in the Manila section

  • Choose "---Manila VA Clinic" for Section
  • Fill in all required fields
    • Initially, try to choose a non-Manila option for the Related office or health care region field
  • Save as Published
    • Confirm that you cannot save the node until you choose the Manila option for the News releases listing field
  • After save, from the event node:view, confirm that the url contains "/manila-va-clinic/" after the domain
  • Edit the news release
  • Save as published
  • After save, from the event node:view, confirm that the url contains "/manila-va-clinic/" after the domain

Make sure to check for regressions

Create an Event in the VA Pacific Islands health care section

  • Choose "---VA Pacific Islands health care" for Section
  • Fill in all required fields
  • Save as Published
  • After save, from the event node:view, confirm that the url DOES NOT contain "/manila-va-clinic/" after the domain
  • Edit the event
    • Save as published
  • After save, from the event node:view, confirm that the url DOES NOT contain "/manila-va-clinic/" after the domain

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 12, 2024 19:48 Destroyed
Copy link

Checking composer.lock changes...

@github-actions github-actions bot added the Facilities Facilities products (VAMC, Vet Center, etc) label Dec 12, 2024
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 13, 2024 08:54 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 14, 2024 08:55 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 15, 2024 08:56 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 16, 2024 08:54 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 16, 2024 19:47 Destroyed
Copy link

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 17, 2024 08:54 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 17, 2024 17:59 Destroyed
Copy link

Checking composer.lock changes...

@omahane omahane requested a review from dsasser December 17, 2024 19:42
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 18, 2024 08:58 Destroyed
Copy link
Contributor

@dsasser dsasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good. I had no problems with the QA test steps as well. Nice work!

@@ -1,3 +1,7 @@
import { Then } from "@badeball/cypress-cucumber-preprocessor";

Then(`I should be at {string}`, (url) => cy.url().should("include", url));

Then(`I should not be at {string}`, (url) =>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@omahane omahane requested a review from a team as a code owner December 19, 2024 00:39
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 19, 2024 00:39 Destroyed
Copy link

Checking composer.lock changes...

@va-cms-bot
Copy link
Collaborator

Cypress Accessibility Violations

/test-data-quo

ID: button-name
Impact: critical
Tags: cat.name-role-value, wcag2a, wcag412, section508, section508.22.a, ACT, TTv5, TT6.a
Description: Ensures buttons have discernible text
Help: Buttons must have discernible text
Nodes:

  • HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Page introduction' field" data-proofing-help="Add an introduction that helps visitors understand if information on the page is relevant to them."> <span aria-hidden="true">i</span> </button>
    Impact: critical
    Target: .field--name-field-intro-text-limited-html > .field__label > .proofing-element-help[role="tooltip"]
    Summary: Fix any of the following:
    Element does not have inner text that is visible to screen readers
    aria-label attribute does not exist or is empty
    aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
    Element has no title attribute
    Element's default semantics were not overridden with role="none" or role="presentation"

  • HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Generate a table of contents from major headings' field" data-proofing-help="By checking this box, all h2's below this point on the page will be linked with with anchor links. This helps users navigate content on very long pages. Do not check this box unless there is at least 2 h2's on the page.">
    Impact: critical
    Target: .field--name-field-table-of-contents-boolean > .field__label > .proofing-element-help[role="tooltip"]
    Summary: Fix any of the following:
    Element does not have inner text that is visible to screen readers
    aria-label attribute does not exist or is empty
    aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
    Element has no title attribute
    Element's default semantics were not overridden with role="none" or role="presentation"

  • HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Main content' field" data-proofing-help="The main body of the page, which appears below the featured content."> <span aria-hidden="true">i</span> </button>
    Impact: critical
    Target: button[data-proofing-help-title="About 'Main content' field"]
    Summary: Fix any of the following:
    Element does not have inner text that is visible to screen readers
    aria-label attribute does not exist or is empty
    aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
    Element has no title attribute
    Element's default semantics were not overridden with role="none" or role="presentation"

@omahane omahane merged commit e42acf3 into main Dec 19, 2024
18 checks passed
@omahane omahane deleted the VACMS-20086-manila-va-clinic-pathautoing branch December 19, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Facilities Facilities products (VAMC, Vet Center, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants