Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 3 Spec Failure: CaregiversAssistanceClaimsController #54272

Closed
1 task
Tracked by #54484
ericboehs opened this issue Feb 28, 2023 · 1 comment · Fixed by department-of-veterans-affairs/vets-api#11993
Closed
1 task
Tracked by #54484

Comments

@ericboehs
Copy link
Contributor

When running our Vets API test suite using Ruby 3.0.5, various examples fail.

One such example is:

rspec ./spec/controllers/v0/caregivers_assistance_claims_controller_spec.rb:25
rspec ./spec/controllers/v0/caregivers_assistance_claims_controller_spec.rb:49

It fails with a 500 (expecting 400).

Logs:

1) V0::CaregiversAssistanceClaimsController#download_pdf behaves like 10-10CG request with missing param: caregivers_assistance_claim requires "caregivers_assistance_claim" param
   Failure/Error: expect(response).to have_http_status(:bad_request)
     expected the response to have status code :bad_request (400) but it was :internal_server_error (500)
   Shared Example Group: "10-10CG request with missing param: caregivers_assistance_claim" called from ./spec/controllers/v0/caregivers_assistance_claims_controller_spec.rb:188
   # ./.bundle/bundle/ruby/3.0.0/gems/super_diff-0.9.0/lib/super_diff/rspec/monkey_patches.rb:45:in `handle_failure'
   # ./spec/controllers/v0/caregivers_assistance_claims_controller_spec.rb:28:in `block (3 levels) in <top (required)>'

AC

  • CaregiversAssistanceClaimsController spec passes for Ruby 3.0.5
@ericboehs ericboehs changed the title Ruby 3 Spec: CaregiversAssistanceClaimsController Ruby 3 Spec Failure: CaregiversAssistanceClaimsController Feb 28, 2023
@oseasmoran73
Copy link
Contributor

department-of-veterans-affairs/vets-api#11929

Moving to review state for @ericboehs to verify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants