Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the parsing of the vagov_info_token cookie #55344

Closed
3 tasks done
asg5704 opened this issue Mar 17, 2023 · 1 comment
Closed
3 tasks done

Fix the parsing of the vagov_info_token cookie #55344

asg5704 opened this issue Mar 17, 2023 · 1 comment
Assignees
Labels
Identity All Identity related tickets identity-frontend

Comments

@asg5704
Copy link
Contributor

asg5704 commented Mar 17, 2023

Description

Currently on VA.gov when the Sign in Service is used to authenticate the vagov_info_token cookie is created as a consumable cookie for the Frontend to get the session expiration. In this Slack thread we want to change this so we can more easily extend our services to others.

**Note, this effort needs to be coordinated launching with vets-api so reach out to a backend engineer before merging in a Pull Request into vets-website

Tasks

  • Modify the formatInfoCookie function to parse the string as JSON instead of the custom parsing
  • Update unit tests as necessary
  • Work with BE team to ensure the PR + their PR is deployed around the same time
@rileyanderson
Copy link
Contributor

New token value example:

{
  "access_token_expiration": "2023-03-17T19:17:31.089Z", 
  "refresh_token_expiration": "2023-03-17T19:29:11.093Z"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Identity All Identity related tickets identity-frontend
Projects
None yet
Development

No branches or pull requests

4 participants