Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change vagov_info_token to JSON #12161

Merged
merged 0 commits into from
Mar 29, 2023
Merged

Change vagov_info_token to JSON #12161

merged 0 commits into from
Mar 29, 2023

Conversation

rileyanderson
Copy link
Contributor

@rileyanderson rileyanderson commented Mar 17, 2023 •
edited
Loading

🚨 COORDINATE WITH FRONTEND BEFORE MERGING 🚨

Summary

Value is currently set as a stringified Ruby hash which is unnecessarily complex to parse.

  • Change value to JSON

Related issue(s)

Testing done

  • Updated specs
  • Tested login, cookie value was json

Screenshots

Screen Shot 2023-03-17 at 1 33 35 PM

What areas of the site does it impact?

Sessions

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@va-vfs-bot va-vfs-bot temporarily deployed to ra-fix-info-cookie-value/main/main March 17, 2023 19:46 Inactive
@rileyanderson rileyanderson force-pushed the ra-fix-info-cookie-value branch from 2f656d4 to 537a516 Compare March 17, 2023 19:47
@rileyanderson rileyanderson marked this pull request as ready for review March 28, 2023 17:26
@rileyanderson rileyanderson requested a review from a team as a code owner March 28, 2023 17:26
asg5704
asg5704 approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@asg5704 asg5704 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, works as expected. Still need to wait on Afia's PR before merging.

@asg5704
Copy link
Contributor

asg5704 commented Mar 28, 2023

DON'T MERGE YET!

@rileyanderson
Copy link
Contributor Author

DON'T MERGE YET!

taunting

@rileyanderson rileyanderson merged commit a8dc46b into master Mar 29, 2023
@rileyanderson rileyanderson deleted the ra-fix-info-cookie-value branch March 29, 2023 20:02
@rileyanderson rileyanderson changed the title DO NOT MERGE - Change vagov_info_token to JSON Change vagov_info_token to JSON Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asg5704 asg5704 asg5704 approved these changes

Assignees
No one assigned
Labels
console-services-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rileyanderson @asg5704 @va-vfs-bot