Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DD] Initial FE implementation #97002

Closed
9 of 17 tasks
Dr-Pongo opened this issue Nov 13, 2024 · 12 comments
Closed
9 of 17 tasks

[DD] Initial FE implementation #97002

Dr-Pongo opened this issue Nov 13, 2024 · 12 comments
Assignees
Labels
unplanned-work Work that was not planned for during Sprint Planning vsa-debt Benefits Team 2 (formerly Debt Resolution,Benefits and Memorials 2)

Comments

@Dr-Pongo
Copy link
Contributor

Dr-Pongo commented Nov 13, 2024

Issue Description

Create an initial version of the Digital Dispute with all required pages. We don't have a URL yet, or a fully functioning vets-api endpoint, so this can live on a remote branch until we're ready to merge.

Definitions:

  • POST: debts_api/v0/digital_disputes
  • App name in vets-website: src/applications/dispute-debt
  • Root URL: <env>/manage-va-debt/dispute-debt/

Links:

Tasks

  • Implement first version of the form for vets-website
  • Include necessary unit tests
  • Once initial draft is up, review with Design

Design and Front End sync on implementation of design

  • Required
  • Complete
  • Not Required

Acceptance Criteria

  • Initial version of Digital dispute is created
  • Initial version has been reviewed with design

Testing

  • N/A if non development work
  • Testing passed and documented in this ticket based off the "Then" statement in the description

Test procedures:
If additional testing steps or credentials to perform testing are needed list them here

Ticket Creation - Definition of Ready

  • Description written
  • Tasks defined
  • Acceptance criteria written
  • Testing defined
  • Add Labels
  • Attach to an Epic
  • Estimate Points
@Dr-Pongo Dr-Pongo added backend digital-dispute Changes relating to Digital Dispute form - debt resolution team frontend vsa-debt Benefits Team 2 (formerly Debt Resolution,Benefits and Memorials 2) labels Nov 13, 2024
@Dr-Pongo Dr-Pongo changed the title Copy of [DD] Create Digital Dispute feature toggle [DD] Initial FE implementation Nov 13, 2024
@Dr-Pongo Dr-Pongo added the unplanned-work Work that was not planned for during Sprint Planning label Nov 18, 2024
@Dr-Pongo
Copy link
Contributor Author

Rolling over because it's a big effort that got started late in the sprint!

@Dr-Pongo
Copy link
Contributor Author

Feature flag is nearly ready to be merged

  • [DD] Create Digital Dispute feature toggle #96916

Initial PR for Digital Dispute in vets-website

Initial PR for DIgital DIspute in vets-api

@Dr-Pongo
Copy link
Contributor Author

Dr-Pongo commented Nov 26, 2024

Opened PR for vets-json-schema which is the true first step in merging on vet-website and vets-api. Waiting on feedback on PRs before proceeding and discussing structure and future steps/work the schema in general and how it aligns with the white list for api.

Edit:
Wanted to add some documentation context. We are following the platform documentation on Moving a Form to Production.

I think to call this effort done we need platform approval and to merge the following (in order)

  1. Add schema for Dispute Debt vets-json-schema#961
  2. [DD] Initial prefill for digital dispute vets-api#19545
  3. [DD] Dispute Debt initial vets-website#33151

@Dr-Pongo
Copy link
Contributor Author

Dr-Pongo commented Dec 2, 2024

After some changes suggested by the team, I opened a support ticket to get a platform review!
https://dsva.slack.com/archives/CBU0KDSB1/p1733156945943879

Edit: reread the docs, and requesting platform approval is 3 days after team reviews 😬 So I will re-request Wednesday
Edit 2EB: We have approval on the first step!

@Dr-Pongo
Copy link
Contributor Author

Dr-Pongo commented Dec 3, 2024

Need to address some of the CI issues for the vets-website to get it to merge (close PR, rebase, open new PR?)
. We can likely close the ticket after that, although the BE PR may block it as well.

@Dr-Pongo
Copy link
Contributor Author

Dr-Pongo commented Dec 4, 2024

So fresh so clean new FE PR (rebased and made new PR to hopefully pickup the schema changes

@Dr-Pongo
Copy link
Contributor Author

Dr-Pongo commented Dec 5, 2024

Rolled into 140 while troubleshooting errors and managing other high priority tasks

@Dr-Pongo
Copy link
Contributor Author

Dr-Pongo commented Dec 6, 2024

Still troubleshooting CI/CD issues

@Dr-Pongo
Copy link
Contributor Author

Dr-Pongo commented Dec 9, 2024

Opened support ticket looking for assistance with CI issues:
https://dsva.slack.com/archives/CBU0KDSB1/p1733761378310059

@Dr-Pongo
Copy link
Contributor Author

Dr-Pongo commented Dec 11, 2024

Still coordinating with Platform to find a resolution. A few fixes have been made in the vets-json-schema to include a necessary property type, but still seeing vets-website CI failures with:

Error: Cannot find module 'jsdom'

Updating as blocked after a test branch confirmed wonky CI issues unrelated to dispute debt specific changes

@Tom-Davis Tom-Davis removed the digital-dispute Changes relating to Digital Dispute form - debt resolution team label Dec 13, 2024
@Dr-Pongo
Copy link
Contributor Author

Supporting PRs got merged to fix some platform level issues, waiting for platform approval. If we don't get it by end of sprint, I'll likely close the PR, and leave notes in FE documentation on the branch that contains the skeleton for Dispute Debt so we can hit the ground running in the new contract

@Dr-Pongo
Copy link
Contributor Author

Closing out at end of sprint/contract. The initial app implementation is in the remote branch dd/97002/new-app-initial, and we'll still need a content-build PR to update the registry with the new URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
unplanned-work Work that was not planned for during Sprint Planning vsa-debt Benefits Team 2 (formerly Debt Resolution,Benefits and Memorials 2)
Projects
None yet
Development

No branches or pull requests

5 participants