Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DD] Initial prefill for digital dispute #19545

Merged
merged 7 commits into from
Dec 11, 2024

Conversation

Dr-Pongo
Copy link
Contributor

@Dr-Pongo Dr-Pongo commented Nov 21, 2024

Summary

Initial commit for prefill for new form dispute debt

  • This work is behind a feature toggle (flipper): YES/NO
    • YES
  • (Summarize the changes that have been made to the platform)
    • New prefill has been added for new app dispute debt
  • (If bug, how to reproduce): N/A
  • (What is the solution, why is this the solution?)
  • (Which team do you work for, does your team own the maintenance of this component?)
    • debt resolution team (#debt-resolution channel on slack)
  • (If introducing a flipper, what is the success criteria being targeted?): N/A

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Describe what the old behavior was prior to the change: No old behavior, this is all new!
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing: We need to merge this to get it to run locally, it's behind a feature flag so specs are all we have at the moment.
  • If this work is behind a flipper:
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • What is the testing plan for rolling out the feature?

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

Copy link

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: config/form_profile_mappings/DISPUTE-DEBT.yml

Copy link

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: config/form_profile_mappings/DISPUTE-DEBT.yml

Copy link

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: config/form_profile_mappings/DISPUTE-DEBT.yml

@digitaldrk digitaldrk force-pushed the dd/97002/dispute-debt-initial branch from 343e4b0 to be14b06 Compare December 9, 2024 19:26
@va-vfs-bot va-vfs-bot temporarily deployed to dd/97002/dispute-debt-initial/main/main December 9, 2024 21:17 Inactive
Copy link
Contributor

@OptionSelect OptionSelect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Copy link
Contributor

@amponce amponce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@digitaldrk digitaldrk merged commit e558321 into master Dec 11, 2024
78 of 80 checks passed
@digitaldrk digitaldrk deleted the dd/97002/dispute-debt-initial branch December 11, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants