Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

211/231 - Remove "keywords" / add "upload a document" feature #901

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

nicksayre
Copy link
Contributor

@nicksayre nicksayre commented Jan 10, 2024

Closes #211 by adding the "upload a document" feature.

Closes #231 by removing the "keywords" section.

Screenshot:
Screenshot 2024-01-10 at 10 25 33 AM

How to review

  • Ensure that the "Key resources for SCOs" heading and following links no longer appear
  • Ensure that the "Upload documents to VA" box appears as designed

<va-featured-content uswds>
<h3 slot="headline">Upload documents to VA</h3>
<p>
The Education File Upload Portal is for certifying officials to upload documents supporting compliance actions, designating or removing certifying officials, and more. The full list of accepted documents is found in the upload portal.
Copy link

@khenson-oddball khenson-oddball Jan 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this wording is a little different than what is in the screenshot for story 211. Just want to make sure that's all good from a Product/Design perspective?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked with design. The most up-to-date wording is in the Figma file, rather than the screen shot, and I followed the Figma.

@nicksayre nicksayre merged commit a7dd4a6 into ns/resources-for-schools-ux Jan 10, 2024
2 checks passed
nicksayre added a commit that referenced this pull request Mar 21, 2024
* 227 - add social media links to school administrators (#895)

Co-authored-by: Nick Sayre <nick.sayre@adhocteam.us>

* 166 - Updated the School Administrator webpage description. (#896)

Co-authored-by: Nick Sayre <nick.sayre@adhocteam.us>

* 228 - Remove "Upcoming Events" (#898)

Co-authored-by: Nick Sayre <nick.sayre@adhocteam.us>

* 229 - update "other resources" section with new content and design (#899)

* 229 - update "other resources" section with new content and design

* 229 - Add underlines to links

---------

Co-authored-by: Nick Sayre <nick.sayre@adhocteam.us>

* 211/231 - Remove "keywords" / add "upload a document" feature (#901)

Co-authored-by: Nick Sayre <nick.sayre@adhocteam.us>

* 226 - Update breadcrumb text (#904)

Co-authored-by: Nick Sayre <nick.sayre@adhocteam.us>

* 210 - Add new heading and link for GovDelivery updates (#905)

Co-authored-by: Nick Sayre <nick.sayre@adhocteam.us>

* 312 - add handbooks section and "On this page" link to it (#907)

Co-authored-by: Nick Sayre <nick.sayre@adhocteam.us>

* 334 - remove breaks in favor of styles, and components; remove non-semantic use of bold elements (#909)

Co-authored-by: Nick Sayre <nick.sayre@adhocteam.us>

* 367 - set all links as opening in the same browsing context (#911)

Co-authored-by: Nick Sayre <nick.sayre@adhocteam.us>

* 373-  Overhaul the Trainings section with a new title, links and descriptions (#913)

Co-authored-by: Nick Sayre <nick.sayre@adhocteam.us>

* Add program approvals section and jump link (#912)

* 314 - add program approvals section and jump link

* 314 - typo

---------

Co-authored-by: Nick Sayre <nick.sayre@adhocteam.us>

* 377 - Update "Understanding Veteran education benefits" section with new heading and content (#917)

Co-authored-by: Nick Sayre <nick.sayre@adhocteam.us>

* 376 - Add "Other Resources" section with content. Update the inner-page link with a corresponding title (#914)

Co-authored-by: Nick Sayre <nick.sayre@adhocteam.us>

* 372 - Add link to "Handbooks" section, and fix two links to PowerPoint files (#919)

Co-authored-by: Nick Sayre <nick.sayre@adhocteam.us>

* 419 - Revise "program approvals" section with latest approved content (#921)

Co-authored-by: Nick Sayre <nick.sayre@adhocteam.us>

* Rrevise "Trainings and webinars" section (#922)

* 420 - Revise "Trainings and webinars" section with newest content

* Update school-administrators.md

update date

---------

Co-authored-by: Nick Sayre <nick.sayre@adhocteam.us>

* 375 - Remove old "upload" section in favor of new one; add inner-page link; update script so that it can affect multiple accordions (#920)

Co-authored-by: Nick Sayre <nick.sayre@adhocteam.us>

* 316 - Replace call-to-action text, graphic, and link; also remove old content (#924)

Co-authored-by: Nick Sayre <nick.sayre@adhocteam.us>

* 430 - Clean up introductory section and sidebar (#925)

Co-authored-by: Nick Sayre <nick.sayre@adhocteam.us>

* 453 - Remove "download: icons; fix typo (#926)

Co-authored-by: Nick Sayre <nick.sayre@adhocteam.us>

* 473 - Priority edits (#930)

Co-authored-by: Nick Sayre <nick.sayre@adhocteam.us>

* 475 - Update graphic, add link to Yellow Ribbon, iteration to "Payment and debt" section (#932)

Co-authored-by: Nick Sayre <nick.sayre@adhocteam.us>

* Merge main

---------

Co-authored-by: Nick Sayre <nick.sayre@adhocteam.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants