changed flipper name and other style issues reported by the PR linter

department-of-veterans-affairs · Apr 26, 2024 · 112ff76 · 112ff76
1 parent 2b3dc71
commit 112ff76
Show file tree

Hide file tree

Showing 3 changed files with 82 additions and 84 deletions.
diff --git a/app/sidekiq/central_mail/submit_form4142_job.rb b/app/sidekiq/central_mail/submit_form4142_job.rb
@@ -52,7 +52,7 @@ class CentralMailResponseError  < Common::Exceptions::BackendServiceException; e
         bgjob_errors: bgjob_errors.merge(new_error)
       )
 
-      api_statsd_key = if Flipper.enabled?(:disability_compensation_form_4142)
+      api_statsd_key = if Flipper.enabled?(:disability_compensation_form4142_supplemental)
                          LIGHTHOUSE_STATSD_KEY_PREFIX
                        else
                          CENTRAL_MAIL_STATSD_KEY_PREFIX
@@ -112,7 +112,7 @@ def processor
     end
 
     def upload_to_api
-      if Flipper.enabled?(:disability_compensation_form_4142)
+      if Flipper.enabled?(:disability_compensation_form4142_supplemental)
         upload_to_lighthouse
       else
         upload_to_central_mail
@@ -144,7 +144,7 @@ def generate_metadata
         'veteranFirstName' => vet_name[:first],
         'veteranLastName' => vet_name[:last],
         'zipCode' => determine_zip,
-        'source' => "Form526Submission va.gov",
+        'source' => 'Form526Submission va.gov',
         'docType' => '4142',
         'businessLine' => '',
         'fileNumber' => filenumber # wipn8923 TODO: validate that this is correct
@@ -156,15 +156,14 @@ def generate_metadata
 
     def determine_zip
       submission.form.dig('form526', 'form526', 'veteran', 'currentMailingAddress', 'zipFirstFive') ||
-      submission.form.dig('form526', 'form526', 'veteran', 'mailingAddress', 'zipFirstFive') ||
-      '00000'
+        submission.form.dig('form526', 'form526', 'veteran', 'mailingAddress', 'zipFirstFive') ||
+        '00000'
     end
 
     def usa_based?
-      country = (
+      country =
         submission.form.dig('form526', 'form526', 'veteran', 'currentMailingAddress', 'country') ||
         submission.form.dig('form526', 'form526', 'veteran', 'mailingAddress', 'country')
-      )
 
       %w[USA US].include?(country&.upcase)
     end

diff --git a/config/features.yml b/config/features.yml
@@ -372,7 +372,7 @@ features:
     actor_type: user
     description: enables sending flashes to BGS for disability_compensation submissions.
     enable_in_development: true
-  disability_compensation_form_4142:
+  disability_compensation_form4142_supplemental:
     actor_type: user
     description: Use Lighthouse API to submit supplemental Form 21-4142 from Form 526EZ submissions
     enable_in_development: true