API-24371-valid-ssn (#11899)

* WIP

* Removes req to always have an ssn

* Fix exception message

* Incremental commit

* Finalize error return, update tests

* Remove unused code

---------

Co-authored-by: Matt Christianson <matthew.christianson1@va.gov>

modules/claims_api/app/controllers/claims_api/v2/veterans/intent_to_file_controller.rb

@@ -60,6 +60,14 @@ def validate
           }
         end
 
+        def validate_ssn(ssn)
+          regex = /^(\d{9})$/
+          if !regex.match?(ssn) || ssn.size != 9
+            error_detail = 'Invalid claimantSsn parameter'
+            raise ::Common::Exceptions::UnprocessableEntity.new(detail: error_detail)
+          end
+        end
+
         private
 
         def intent_to_file_options(type)
@@ -76,7 +84,10 @@ def intent_to_file_options(type)
         # BGS requires at least 1 of 'participant_claimant_id' or 'claimant_ssn'
         def handle_claimant_fields(options:, params:, target_veteran:)
           claimant_ssn = params[:claimantSsn]
-
+          if claimant_ssn.present?
+            claimant_ssn = claimant_ssn.gsub('-', '')
+            validate_ssn(claimant_ssn)
+          end
           options[:claimant_ssn] = claimant_ssn if claimant_ssn
 
           # if claimant_ssn field was not provided, then default to sending 'participant_claimant_id'

modules/claims_api/spec/requests/v2/veterans/intent_to_files_request_spec.rb

@@ -411,7 +411,7 @@
                 with_okta_user(scopes) do |auth_header|
                   survivor_data = data
                   survivor_data[:type] = 'survivor'
-                  survivor_data[:claimantSsn] = '123456'
+                  survivor_data[:claimantSsn] = '123456789'
                   post itf_submit_path, params: survivor_data, headers: auth_header
                   expect(response.status).to eq(200)
                 end
@@ -428,6 +428,18 @@
                 end
               end
             end
+
+            context 'when invalid parameter is provided' do
+              it 'returns a 422' do
+                with_okta_user(scopes) do |auth_header|
+                  survivor_data = data
+                  survivor_data[:type] = 'survivor'
+                  survivor_data[:claimantSsn] = 'abcdefghi'
+                  post itf_submit_path, params: survivor_data, headers: auth_header
+                  expect(response.status).to eq(422)
+                end
+              end
+            end
           end
         end