Revert "Prevent redis cache if data is nil (#12494)" (#12495)

This reverts commit 23c7f1f.
department-of-veterans-affairs · Apr 27, 2023 · f9a781d · f9a781d
1 parent 9df5c53
commit f9a781d
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/modules/mobile/app/controllers/mobile/v1/immunizations_controller.rb b/modules/mobile/app/controllers/mobile/v1/immunizations_controller.rb
@@ -37,7 +37,7 @@ def immunizations
           Rails.logger.info('mobile immunizations cache fetch', user_uuid: @current_user.uuid)
         else
           immunizations = immunizations_adapter.parse(service.get_immunizations)
-          Mobile::V0::Immunization.set_cached(@current_user, immunizations) if immunizations.present?
+          Mobile::V0::Immunization.set_cached(@current_user, immunizations)
           Rails.logger.info('mobile immunizations service fetch', user_uuid: @current_user.uuid)
         end
 

diff --git a/modules/mobile/app/helpers/mobile/appointments_cache_interface.rb b/modules/mobile/app/helpers/mobile/appointments_cache_interface.rb
@@ -21,10 +21,7 @@ def fetch_appointments(user:, start_date: nil, end_date: nil, fetch_cache: true,
 
       appointments, failures = fetch_from_external_service(user, search_start_date, search_end_date)
 
-      if appointments.present? && (cache_on_failures == true || failures.blank?)
-        Mobile::V0::Appointment.set_cached(user,
-                                           appointments)
-      end
+      Mobile::V0::Appointment.set_cached(user, appointments) if cache_on_failures == true || failures.blank?
 
       Rails.logger.info('mobile appointments service fetch', user_uuid: user.uuid)
       [appointments, failures]

diff --git a/modules/mobile/app/workers/mobile/v0/pre_cache_claims_and_appeals_job.rb b/modules/mobile/app/workers/mobile/v0/pre_cache_claims_and_appeals_job.rb
@@ -19,7 +19,7 @@ def perform(uuid)
           Rails.logger.warn('mobile claims pre-cache set failed', user_uuid: uuid,
                                                                   errors:)
         else
-          Mobile::V0::ClaimOverview.set_cached(user, data) if data.present?
+          Mobile::V0::ClaimOverview.set_cached(user, data)
           Rails.logger.info('mobile claims pre-cache set succeeded', user_uuid: uuid)
         end
       end