Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API 22838 Claim status response formatting #11605

Merged
merged 0 commits into from
Feb 1, 2023

Conversation

mchristiansonVA
Copy link
Contributor

@mchristiansonVA mchristiansonVA commented Jan 19, 2023

Summary

  • Updated Blueprinter to conform to VA.gov expectations for claim status json responses.

Related issue(s)

API-22838

Testing done

Manual testing via Postman to confirm json response structure meets requirements.

What areas of the site does it impact?

  • ClaimsAPI: claimsController, claimsBlueprint

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

@va-vfs-bot va-vfs-bot temporarily deployed to API-22838_CST_reponse_formatting/main/main January 19, 2023 22:25 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to API-22838_CST_reponse_formatting/main/main January 20, 2023 20:41 Inactive
@mchristiansonVA mchristiansonVA self-assigned this Jan 20, 2023
@mchristiansonVA mchristiansonVA added Lighthouse lighthouse claimsApi modules/claims_api labels Jan 20, 2023
@mchristiansonVA mchristiansonVA marked this pull request as ready for review January 20, 2023 20:56
@mchristiansonVA mchristiansonVA requested review from a team as code owners January 20, 2023 20:56
FonzMP
FonzMP previously approved these changes Jan 23, 2023
Copy link
Contributor

@FonzMP FonzMP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@FonzMP FonzMP dismissed their stale review January 24, 2023 02:38

Sorry, dismissing this review. we need to update the docs when we make this change.

@va-vfs-bot va-vfs-bot temporarily deployed to API-22838_CST_reponse_formatting/main/main January 25, 2023 15:38 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to API-22838_CST_reponse_formatting/main/main January 25, 2023 16:27 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to API-22838_CST_reponse_formatting/main/main January 25, 2023 19:13 Inactive
@FonzMP
Copy link
Contributor

FonzMP commented Jan 25, 2023

@mchristiansonVA - looks like you may have ran the old rswag tool. apologies - we should update the documentation. we don't need the changes to v1 - they'll always populate new ID's in it's current state. v2 needs to build in to the "environment specific" swagger files.

v2 should build in the v2/dev/swagger.json and v2/production/swagger.json. Use
bundle exec rake rswag:claims_api:build and then just ignore the v1 changes.

@va-vfs-bot va-vfs-bot temporarily deployed to API-22838_CST_reponse_formatting/main/main January 26, 2023 15:40 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to API-22838_CST_reponse_formatting/main/main January 26, 2023 15:53 Inactive
FonzMP
FonzMP previously approved these changes Jan 30, 2023
Copy link
Contributor

@FonzMP FonzMP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@FonzMP FonzMP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mchristiansonVA mchristiansonVA merged commit f898946 into master Feb 1, 2023
@mchristiansonVA mchristiansonVA deleted the API-22838_CST_reponse_formatting branch February 1, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants