Reject missing icn on HLR\SC index #11612
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The index endpoint for both Higher Level Reviews and Supplemental Claims were both leaking data when called without an ICN. They were both returning appeals that did not have an ICN because we unintendedly issuing a query like ~"where ICN = nil" when index was called without an ICN provided.
Added code to reject appeals index calls without an X-VA-ICN header provided.
My banana -peels team owns this code
Related issue(s)
API-23079
Testing done
Prior to this change, calls to index without supplying and ICN were not rejected AND those calls were returning ALL appeals records that did not have an ICN in the veterans-icn column
Added unit test to make sure index calls without an X-VA-ICN header are rejected
Screenshots
Note: Optional
What areas of the site does it impact?
index route for Higher Level Reviews and Supplemental Claims
Acceptance criteria