Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject missing icn on HLR\SC index #11612

Merged
merged 0 commits into from
Feb 4, 2023

Conversation

michelpmcdonald
Copy link
Contributor

@michelpmcdonald michelpmcdonald commented Jan 20, 2023

Summary

The index endpoint for both Higher Level Reviews and Supplemental Claims were both leaking data when called without an ICN. They were both returning appeals that did not have an ICN because we unintendedly issuing a query like ~"where ICN = nil" when index was called without an ICN provided.

Added code to reject appeals index calls without an X-VA-ICN header provided.

My banana -peels team owns this code

Related issue(s)

API-23079

Testing done

Prior to this change, calls to index without supplying and ICN were not rejected AND those calls were returning ALL appeals records that did not have an ICN in the veterans-icn column

Added unit test to make sure index calls without an X-VA-ICN header are rejected

Screenshots

Note: Optional

What areas of the site does it impact?

index route for Higher Level Reviews and Supplemental Claims

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution

@va-vfs-bot va-vfs-bot temporarily deployed to API-23079_appeals_show_blank_icn_leak/main/main January 20, 2023 17:37 Inactive
@michelpmcdonald michelpmcdonald added Lighthouse lighthouse appeals Lighthouse API appeals labels Jan 20, 2023
@va-vfs-bot va-vfs-bot temporarily deployed to API-23079_appeals_show_blank_icn_leak/main/main January 20, 2023 21:52 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to API-23079_appeals_show_blank_icn_leak/main/main January 23, 2023 15:40 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to API-23079_appeals_show_blank_icn_leak/main/main January 26, 2023 04:08 Inactive
@michelpmcdonald michelpmcdonald marked this pull request as ready for review January 26, 2023 04:30
@michelpmcdonald michelpmcdonald requested review from a team as code owners January 26, 2023 04:30
kristen-brown
kristen-brown previously approved these changes Jan 26, 2023
Copy link
Contributor

@kristen-brown kristen-brown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@va-vfs-bot va-vfs-bot temporarily deployed to API-23079_appeals_show_blank_icn_leak/main/main January 31, 2023 18:01 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to API-23079_appeals_show_blank_icn_leak/main/main January 31, 2023 21:00 Inactive
@michelpmcdonald michelpmcdonald added the banana-peels Lighthouse Banana Peels Team label Feb 2, 2023
@cilestin cilestin merged commit 3241034 into master Feb 4, 2023
@cilestin cilestin deleted the API-23079_appeals_show_blank_icn_leak branch February 4, 2023 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
appeals Lighthouse API appeals banana-peels Lighthouse Banana Peels Team Lighthouse lighthouse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants