Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[51833] updates AVC created & updated log #11657

Merged
merged 0 commits into from
Jan 31, 2023
Merged

[51833] updates AVC created & updated log #11657

merged 0 commits into from
Jan 31, 2023

Conversation

bramleyjl
Copy link
Contributor

@bramleyjl bramleyjl commented Jan 26, 2023 •
edited
Loading

Summary

  • Updates to new/updated AVC log formatting

Related issue(s)

Testing done

  • Unit spec updated for new format
  • Logins with SSOe & SiS to test new format

What areas of the site does it impact?

  • Authentication

Acceptance criteria

  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected

@bramleyjl bramleyjl self-assigned this Jan 26, 2023
@bramleyjl bramleyjl added identity identity-backend Identity team backend label labels Jan 26, 2023
@va-vfs-bot va-vfs-bot temporarily deployed to 51833_avc_logging_tweaks/main/main January 26, 2023 18:12 Inactive
@bramleyjl bramleyjl requested a review from bosawt January 26, 2023 18:16
@bramleyjl bramleyjl marked this pull request as ready for review January 26, 2023 18:16
@bramleyjl bramleyjl requested review from a team as code owners January 26, 2023 18:16
@bramleyjl bramleyjl changed the title [51833] updates AVC updated log [51833] updates AVC created & updated log Jan 26, 2023
@va-vfs-bot va-vfs-bot temporarily deployed to 51833_avc_logging_tweaks/main/main January 26, 2023 18:25 Inactive
@bramleyjl bramleyjl force-pushed the 51833_avc_logging_tweaks branch from 553d404 to c88de64 Compare January 27, 2023 18:02
@va-vfs-bot va-vfs-bot temporarily deployed to 51833_avc_logging_tweaks/main/main January 27, 2023 18:03 Inactive
@bramleyjl bramleyjl force-pushed the 51833_avc_logging_tweaks branch from c88de64 to 756fde7 Compare January 30, 2023 18:33
@platform-support-slack-integration platform-support-slack-integration bot mentioned this pull request Jan 31, 2023
Closed
@bramleyjl bramleyjl merged commit 3219095 into master Jan 31, 2023
@bramleyjl bramleyjl deleted the 51833_avc_logging_tweaks branch January 31, 2023 17:22
@bramleyjl bramleyjl mentioned this pull request Jan 31, 2023
Closed
@bramleyjl
Copy link
Contributor Author

Confirmed these logs are appearing in Datadog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjohnson2011 rjohnson2011 rjohnson2011 approved these changes

@bosawt bosawt Awaiting requested review from bosawt

Assignees

@bramleyjl bramleyjl

Labels
console-services-review identity identity-backend Identity team backend label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bramleyjl @rjohnson2011 @va-vfs-bot