Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capture Appointment Type of Care, Provider's Info in Loki #11658

Merged
merged 0 commits into from
Feb 1, 2023
Merged

Capture Appointment Type of Care, Provider's Info in Loki #11658

merged 0 commits into from
Feb 1, 2023

Conversation

ajmagdub
Copy link
Contributor

@ajmagdub ajmagdub commented Jan 26, 2023 •
edited
Loading

Summary

Added logging of Appointment Type of Care and Provider information to aid in Product and Design inquiries.

Related issue(s)

department-of-veterans-affairs/va.gov-team#38313

Testing done

Added rspec tests to verify duplicate logging is not done in request.

Acceptance criteria

  • I added unit tests and integration tests for each feature (if applicable).
  • Events are being sent to the appropriate logging solution
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

@github-actions github-actions bot added the VAOS Va Online Scheduling Contract label Jan 26, 2023
@va-vfs-bot va-vfs-bot temporarily deployed to 38313-capture-type-of-care-providers-info-in-loki/main/main January 26, 2023 20:36 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 38313-capture-type-of-care-providers-info-in-loki/main/main January 27, 2023 21:37 Inactive
@ajmagdub ajmagdub marked this pull request as ready for review January 30, 2023 15:16
@ajmagdub ajmagdub requested review from a team as code owners January 30, 2023 15:16
cferris32
cferris32 approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@cferris32 cferris32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@platform-support-slack-integration platform-support-slack-integration bot mentioned this pull request Feb 1, 2023
Closed
@ajmagdub ajmagdub merged commit 52eafbf into master Feb 1, 2023
@ajmagdub ajmagdub deleted the 38313-capture-type-of-care-providers-info-in-loki branch February 1, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjohnson2011 rjohnson2011 rjohnson2011 approved these changes

@cferris32 cferris32 cferris32 approved these changes

Assignees
No one assigned
Labels
VAOS Va Online Scheduling Contract
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ajmagdub @cferris32 @rjohnson2011 @va-vfs-bot