Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[52756] Disable FSR worker retries #11685

Merged
merged 0 commits into from
Feb 1, 2023
Merged

Conversation

ScottyRJames
Copy link
Contributor

@ScottyRJames ScottyRJames commented Jan 31, 2023

Summary

Both VBA and VHA have noticed duplicate submissions of FSRs, we believe this is related to a bug regarding the worker retrying a failed job when the submission was actually successful. Will need to validate we are capturing real errors and only retrying the worker on that case.

Related issue(s)

- department-of-veterans-affairs/va.gov-team#52756

Testing done

  • Rspec passing

Screenshots

N/A

What areas of the site does it impact?

FSR submission

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@ScottyRJames ScottyRJames merged commit a460552 into master Feb 1, 2023
@ScottyRJames ScottyRJames deleted the 52756-disable-fsr-retries branch February 1, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants