Allow none as a valid evidence type for Supp Claims #11689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michelpmcdonald
added
Lighthouse
va-vfs-bot
temporarily deployed
to
API-23202_no_evidence_scs/main/main
va-vfs-bot
temporarily deployed
to
API-23202_no_evidence_scs/main/main
va-vfs-bot
temporarily deployed
to
API-23202_no_evidence_scs/main/main
caseywilliams
requested changes
Feb 1, 2023
va-vfs-bot
temporarily deployed
to
API-23202_no_evidence_scs/main/main
va-vfs-bot
temporarily deployed
to
API-23202_no_evidence_scs/main/main
9 tasks
caseywilliams
approved these changes
Feb 1, 2023
cilestin
previously requested changes
Feb 1, 2023
michelpmcdonald
dismissed
cilestin’s stale review
Going to fix in a follow up
This was referenced Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Due to some PACT act adjustments, Supplemental Claims no longer requires claimant specified supporting evidence.
To support this, we updated Supplemental Claims' JSON schema to allow evidenceSubmission::evidenceType to be set to "none".
EvidenceType is an array, if "none" is included, the other two values, "upload" and "retrieval", cannot be included in the EvidenceType Array, this is enforced in the Schema.
team banana-peels owns this code.
A schema change requires our Swagger Documentation to be updated, although this ticket only made a change to Supplemental Claims Documentation, some previous changes were made to our Swagger "source" files, but the Swagger Documents were not re-generated at that time. When I re-generated our Swagger docs for this ticket, I also picked up some some swagger doc changes from that previous ticket, we decided to keep all the Swagger Docs changes in this PR.
Related issue(s)
Testing done
Tested via manual testing and with unit test coverage
Screenshots
What areas of the site does it impact?
This impacts our Supplemental Claims "create" endpoint
Acceptance criteria
Requested Feedback
(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?