Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api 22862 fixes other test users link #11691

Merged
merged 0 commits into from
Feb 1, 2023
Merged

Conversation

jkelly-va
Copy link
Contributor

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

  • The test user link in the VC V0 OAS has been updated to point directly to the VC Sandbox test users
  • This is not a bug fix
  • This is a solution for users being brought to the wrong test users page
  • Ninjapigs - yes, we own the maintenance of this component
  • No flippers were added or changed

Related issue(s)

Testing done

  • The test user link led to a page that had an option to see Veteran Verification and other API test users, but not test users for VC
  • Tested that the new link was working and led to the correct Test Users
  • Tested the new link and it led to the correct Test Users page

Screenshots

Note: Optional

What areas of the site does it impact?

The VETERAN_CONFIRMATION.yml file was the only item updated

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated VC Developer Portal
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@jkelly-va jkelly-va merged commit 6a81d2e into master Feb 1, 2023
@jkelly-va jkelly-va deleted the API-22862-FixTestUsersLink branch February 1, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants