Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VaNotify - Update params for confirmation email to 5490 #11706

Merged

Conversation

nathanbwright
Copy link
Contributor

Summary

  • Updates params for confirmation email to form 5490
  • Sending email is behind a feature flag which will be removed once once we have incrementally rolled this out and verified that it is working as expected.

Related issue(s)

Testing done

  • Added automated testing for sending confirmation email to the SavedClaim::EducationBenefits.
  • We will do testing in staging before rolling this out in prod.

Screenshots

Note: Optional

What areas of the site does it impact?

Updates params for email confirmation to veterans when they have successfully submitted a 5490 form.

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@nathanbwright nathanbwright merged commit 916f5a7 into master Feb 3, 2023
@nathanbwright nathanbwright deleted the vanotify-692/5490-confirmation-email-updates-2 branch February 3, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants