Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api 23200 move a bgs service #11710

Merged
merged 0 commits into from
Feb 9, 2023
Merged

Api 23200 move a bgs service #11710

merged 0 commits into from
Feb 9, 2023

Conversation

acovrig
Copy link
Contributor

@acovrig acovrig commented Feb 2, 2023

Summary

  • Move a service from the BGS gem to vets-api in an attempt to troubleshoot 499 errors.

Related issue(s)

Testing done

  • rspec

What areas of the site does it impact?

  • v1

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@acovrig acovrig added Lighthouse lighthouse claimsApi modules/claims_api labels Feb 2, 2023
@acovrig acovrig requested review from stiehlrod and FonzMP February 2, 2023 21:22
@acovrig acovrig requested a review from a team as a code owner February 2, 2023 21:22
@acovrig acovrig self-assigned this Feb 2, 2023
@acovrig acovrig requested a review from a team as a code owner February 2, 2023 21:22
@github-actions
Copy link

github-actions bot commented Feb 2, 2023

1 Error
🚫 This PR changes 793 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, those exceeding
500 will not be reviewed, nor will they be allowed to merge. Please break this PR up into
smaller ones.

If you have reason to believe that this PR should be granted an exception, please see the
Submitting pull requests for approval - FAQ.

File Summary

Files

  • config/initializers/bgs.rb (+14/-0)

  • modules/claims_api/app/controllers/claims_api/v1/forms/base.rb (+9/-0)

  • modules/claims_api/app/controllers/claims_api/v1/forms/power_of_attorney_controller.rb (+1/-1)

  • modules/claims_api/lib/claims_api/bgs_service/base.rb (+209/-0)

  • modules/claims_api/lib/claims_api/bgs_service/bgs.rb (+34/-0)

  • modules/claims_api/lib/claims_api/bgs_service/errors.rb (+120/-0)

  • modules/claims_api/lib/claims_api/bgs_service/services.rb (+85/-0)

  • modules/claims_api/lib/claims_api/bgs_service/services/benefit_claims.rb (+57/-0)

  • modules/claims_api/lib/claims_api/bgs_service/services/intent_to_file.rb (+110/-0)

  • modules/claims_api/lib/claims_api/bgs_service/services/person.rb (+55/-0)

  • modules/claims_api/lib/claims_api/bgs_service/string_utils.rb (+66/-0)

  • modules/claims_api/spec/requests/v1/power_of_attorney_request_spec.rb (+12/-12)

  • modules/claims_api/spec/requests/v1/rswag_power_of_attorney_request_spec.rb (+4/-4)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/
    

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

Copy link
Contributor

@FonzMP FonzMP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants