Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving around #11733

Merged
merged 0 commits into from
Feb 7, 2023
Merged

Moving around #11733

merged 0 commits into from
Feb 7, 2023

Conversation

kylesoskin
Copy link
Contributor

@kylesoskin kylesoskin commented Feb 6, 2023 •
edited
Loading

Summary

Moving file around

Related issue(s)

Testing done

local, rspec

What areas of the site does it impact?

backend,sidekiq

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@va-vfs-bot va-vfs-bot temporarily deployed to ksoskin/resolve_unknown_class_error/main/main February 6, 2023 17:37 Inactive
@kylesoskin kylesoskin marked this pull request as ready for review February 6, 2023 17:38
@kylesoskin kylesoskin requested review from a team as code owners February 6, 2023 17:38
@va-vfs-bot va-vfs-bot temporarily deployed to ksoskin/resolve_unknown_class_error/main/main February 6, 2023 17:53 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to ksoskin/resolve_unknown_class_error/main/main February 6, 2023 20:54 Inactive
@platform-support-slack-integration platform-support-slack-integration bot mentioned this pull request Feb 7, 2023
Closed
@kylesoskin kylesoskin merged commit 3ab31c2 into master Feb 7, 2023
@kylesoskin kylesoskin deleted the ksoskin/resolve_unknown_class_error branch February 7, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjohnson2011 rjohnson2011 rjohnson2011 approved these changes

Assignees
No one assigned
Labels
console-services-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kylesoskin @rjohnson2011 @va-vfs-bot