-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update UserAcceptableVerifiedCredentialCountsJob to use StatsD #11780
Conversation
Generated by 🚫 Danger |
Closing for #11854 |
Reopening. Replacing current logging solution with StatsD |
3c672ba
to
48b6b93
Compare
spec/jobs/identity/user_acceptable_verified_credential_totals_job_spec.rb
Outdated
Show resolved
Hide resolved
spec/jobs/identity/user_acceptable_verified_credential_totals_job_spec.rb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense. My only comments would be around potential for performance issues, but I'm not super concerned since it's a Sidekiq job once a day. And if we ever see issues with the queries not completing or something we can revisit (I doubt this will be an issue)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Summary
Run Sidekiq cron job daily to set StatsD gauges with
user_avc
totals.user_avc_totals.{proivider}.{scope}.total
How to test
bundle exec rails c
bundle exec sidekiq
tail -f log/statsd.log
http://localhost:3000/sidekiq/recurring-jobs
UserAcceptableVerifiedCredentialTotals
user_avc_totals.*.*.total
statsd keysRelated issue(s)
Testing done
Screenshots
What areas of the site does it impact?
(Describe what parts of the site are impacted andifcode touched other areas)
Acceptance criteria
Requested Feedback