Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API-23874 Track SC evidenceType on records #11787

Merged
merged 0 commits into from
Mar 2, 2023

Conversation

cilestin
Copy link
Contributor

@cilestin cilestin commented Feb 14, 2023

Summary

This change tracks the evidence type a supplemental claim was submitted with, for business intelligence & statistics uses.

Update: I've verified the models in Production have the metadata key, as needed for this PR. Ready for review!

Related issue(s)

Testing done

  • Ensured creating a Supplemental Claim had its metadata['evidenceType'] filled as expected

What areas of the site does it impact?

  • None, currently - the supplemental claims endpoints do not currently have a consumer.

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@cilestin cilestin added Lighthouse lighthouse banana-peels Lighthouse Banana Peels Team labels Feb 14, 2023
@cilestin cilestin requested review from a team as code owners February 14, 2023 01:21
@va-vfs-bot va-vfs-bot temporarily deployed to API-23874-appeals-metadata-col/main/main February 14, 2023 01:28 Inactive
@cilestin
Copy link
Contributor Author

See #11788 for the database migration PR.

@cilestin cilestin force-pushed the API-23874-appeals-metadata-col branch from 8ccbf1c to 7e66278 Compare February 14, 2023 01:33
@cilestin cilestin added the NOT_YET Don't merge this PR w/o the authors permission label Feb 14, 2023
@va-vfs-bot va-vfs-bot temporarily deployed to API-23874-appeals-metadata-col/main/main February 14, 2023 01:42 Inactive
kristen-brown
kristen-brown previously approved these changes Feb 14, 2023
@cilestin cilestin merged commit 11a867d into master Mar 2, 2023
@cilestin cilestin deleted the API-23874-appeals-metadata-col branch March 2, 2023 18:05
@michelpmcdonald
Copy link
Contributor

Tested in staging using va.gov to create Supp claims, metadata does have the evidenceType now as expected:
metadata: {"evidenceType"=>["retrieval", "upload"]}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
banana-peels Lighthouse Banana Peels Team Lighthouse lighthouse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants